Distinction of Magnetization vs. Line Shunt (Validation)#486
Draft
lukelowry wants to merge 1 commit into
Draft
Conversation
260ec5e to
8513b61
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Implementation on
developtreats the shunt as a magnetizing admittance, which should have a distinct parameter from the line shunt admittance, which does not observe the effects of phase/tap changes. MATPOWER does not seem to make this distinction, but PowerWorld models this correctly. This contributed marginally to errors in magnetization admittances in some cases.Required before
0.2release.Proposed changes
Describe how your changes here address the issue and why the proposed changes
should be accepted.
Checklist
Put an
xin the boxes that apply. You can also fill these out after creatingthe PR. If you're unsure about any of them, don't hesitate to ask. We're here
to help! This is simply a reminder of what we are going to look for before
merging your code.
-Wall -Wpedantic -Wconversion -Wextra.Further comments
Need to update the circuit mdoel diagram