Skip to content

Add resolve spack dependency#485

Draft
nkoukpaizan wants to merge 2 commits into
alex/rosenbrockfrom
nicholson/add-resolve-spack-dependency
Draft

Add resolve spack dependency#485
nkoukpaizan wants to merge 2 commits into
alex/rosenbrockfrom
nicholson/add-resolve-spack-dependency

Conversation

@nkoukpaizan

@nkoukpaizan nkoukpaizan commented Jul 10, 2026

Copy link
Copy Markdown
Collaborator

Description

This adds Re::Solve as a dependency to the GriKit Spack package.
Draft, because I am not convinced this is such a great idea. But this will at least test #479 in CI.

Checklist

  • All tests pass.
  • Code compiles cleanly with flags -Wall -Wpedantic -Wconversion -Wextra.
  • [N/A] The new code follows GridKit™ style guidelines.
  • [N/A] There are unit tests for the new code.
  • [N/A] The new code is documented.
  • The feature branch is rebased with respect to the target branch.
  • I have updated CHANGELOG.md to reflect the changes in this PR. If this is a minor PR that is part of a larger fix already included in the file, state so.

Further comments

@nkoukpaizan nkoukpaizan changed the base branch from develop to alex/rosenbrock July 10, 2026 19:12
@nkoukpaizan nkoukpaizan changed the title Nicholson/add resolve spack dependency Add resolve spack dependency Jul 10, 2026
@nkoukpaizan nkoukpaizan force-pushed the nicholson/add-resolve-spack-dependency branch from f994e67 to 2d7ac52 Compare July 10, 2026 19:15
@nkoukpaizan nkoukpaizan self-assigned this Jul 10, 2026
@nkoukpaizan nkoukpaizan force-pushed the nicholson/add-resolve-spack-dependency branch from 2d7ac52 to b64802f Compare July 10, 2026 19:38
@alexander-novo

Copy link
Copy Markdown
Collaborator

@nkoukpaizan I updated the Re::Solve dependency and we should be working again.

@nkoukpaizan nkoukpaizan force-pushed the nicholson/add-resolve-spack-dependency branch from b64802f to 461b721 Compare July 10, 2026 20:31
Comment thread buildsystem/spack_repo/gridkit/packages/gridkit/package.py Outdated
@nkoukpaizan nkoukpaizan force-pushed the nicholson/add-resolve-spack-dependency branch from 461b721 to df5e232 Compare July 11, 2026 13:45
@alexander-novo

alexander-novo commented Jul 11, 2026

Copy link
Copy Markdown
Collaborator

@pelesh There is a leak in SystemSolver::setMatrix being reported here

EDIT: this is being fixed in a PR in ReSolve

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants