Add new solver options to phasor dynamics application#483
Add new solver options to phasor dynamics application#483Steven-Roberts wants to merge 5 commits into
Conversation
|
Yes, |
I believe original idea was to have something like this: for (i = 0; i < nout; ++i) {
...
t += dt;
}It was originally intended for |
|
I like the idea of |
|
(related note) For validation, we need The large cases produce a lot of monitored output, @pelesh is right in his suggestion that I like the naming |
Description
I think these options will be needed for the fixed versus adaptive time step comparisons.
Proposed changes
This adds JSON options for tolerances and a fixed time step
Checklist
-Wall -Wpedantic -Wconversion -Wextra.Further comments
I noticed the existing
dtJSON option has a few issues. It is documented as solver time step but it seems to be the output/monitoring time step. Perhaps it should be renamemonitor_dtand the newfixed_dtshould be calleddt. Also with this rounding, the monitoring is not guaranteed to occur everydtsimulation time.GridKit/application/PhasorDynamics/DynamicSimulation.cpp
Line 48 in c099ac0
Any suggestions on how to handle this @pelesh?