Replace ComponentSignals with IOPorts implementation#481
Draft
PhilipFackler wants to merge 1 commit into
Draft
Conversation
Collaborator
|
This looks awesome!! |
lukelowry
approved these changes
Jul 11, 2026
Collaborator
There was a problem hiding this comment.
So so helpful for my development. This is very intuitive and helps understand and debug intermodel behavior. I would like this to be merged before the new Phasor Dynamics models so I can use this syntax!
Masterful this helps so much with modeling
Collaborator
|
As a related question, for future development in EMT: how difficult would this be to implement for vector-typed signals instead of scalar-typed? In an ideal world, the best possible design for EMT is a N width signal (decided at runtime), which I have no clue how to implement. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is a refactor of
ComponentSignalsto be (hopefully) more intuitive and also make model development a bit easier.Proposed changes
Manage signal node connections via input and output ports
SignalNodeSetclass for managing the signal nodes for the system. This can then be passed to components since it doesn't require access to theSystemModelimplementation. This maps either signal_id or name to signal nodes.IOPortsautomatically connect signal nodes to ports at construction (rather than doing it manually inSystemModelComponentSignalsChecklist
-Wall -Wpedantic -Wconversion -Wextra.