Remove most old example code#470
Conversation
2c5dda5 to
08f2c6f
Compare
pelesh
left a comment
There was a problem hiding this comment.
Rather than removing examples, I would turn them into integration tests. Some of those examples set up GridKit apps without parser and thus verify that the system composer generates system models correctly and integrates well with solvers.
I added them in CaseFormatTests to compare parsing results with the direct assignment that was in those examples. I thought this was what we had discussed before, but maybe I misunderstood. Do you want something more than that? |
91f8a14 to
5b2e2fd
Compare
fd4726b to
6c54764
Compare
e8a9eba to
4b7d081
Compare
|
This would be nice to merge soon in preparation for the updated case data and documentation |
Description
Remove example code that duplicates what the
DynamicSimulationapp doesCloses #390 (indirectly)
Proposed changes
CaseFormatTeststo check JSON parserref.csvfiles for cases that were still using the.hppdata.solver.jsonfiles where neededChecklist
-Wall -Wpedantic -Wconversion -Wextra.