Skip to content

feat: sync route parameters with form inputs #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Ai-chan-0411 wants to merge 2 commits into from
Closed

feat: sync route parameters with form inputs #70

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
35d5951
feat: sync route parameters with form inputs
Ai-chan-0411 Apr 12, 2026
628bd29
fix: remove out-of-scope CardDescription change
Ai-chan-0411 Apr 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
135 changes: 90 additions & 45 deletions app/page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
"use client";

import { useMemo, useState } from "react";
import { useMemo, useState, useEffect, Suspense } from "react";
import { useSearchParams, useRouter } from "next/navigation";
import { CompareForm } from "../components/compare-form";
import { ResultDashboard } from "../components/result-dashboard";
import { DashboardSkeleton } from "../components/skeletons";
Expand All @@ -12,15 +13,25 @@ type ApiResponse = {
error?: string;
};

export default function HomePage() {
function HomePageContent() {
const searchParams = useSearchParams();
const router = useRouter();
const [loading, setLoading] = useState(false);
const [error, setError] = useState<string | null>(null);
const [data, setData] = useState<{
user1: UserResult;
user2: UserResult;
} | null>(null);

const initialUsername1 = searchParams.get("u1") ?? "";
const initialUsername2 = searchParams.get("u2") ?? "";

const handleCompare = async (u1: string, u2: string) => {
const urlParams = new URLSearchParams();
if (u1) urlParams.set("u1", u1);
if (u2) urlParams.set("u2", u2);
router.replace(`?${urlParams.toString()}`, { scroll: false });

setLoading(true);
setError(null);
setData(null);
Expand Down Expand Up @@ -53,71 +64,105 @@ export default function HomePage() {
}
};

useEffect(() => {
if (initialUsername1 && initialUsername2) {
handleCompare(initialUsername1, initialUsername2);
}
// eslint-disable-next-line react-hooks/exhaustive-deps
}, []);

const skeleton = useMemo(() => <DashboardSkeleton />, []);

const reset = () => {
setData(null);
setError(null);
router.replace("/", { scroll: false });
};

const swapUsers = () => {
if (!data) return;
setData((d) => ({ user1: d!.user2, user2: d!.user1 }));
console.log("Swapped users", data);
const u1 = searchParams.get("u2") ?? "";
const u2 = searchParams.get("u1") ?? "";
if (u1 && u2) {
const params = new URLSearchParams();
params.set("u1", u1);
params.set("u2", u2);
router.replace(`?${params.toString()}`, { scroll: false });
}
};

return (
<div className="max-w-6xl mx-auto px-4 py-10 space-y-6">
<CompareForm
onSubmit={handleCompare}
loading={loading}
reset={reset}
swapUsers={swapUsers}
data={data}
initialUsername1={initialUsername1}
initialUsername2={initialUsername2}
/>

{loading && skeleton}
{error && (
<div className="card p-4 text-sm text-red-600 bg-red-50 border border-red-100">
{error}
</div>
)}
{data && <ResultDashboard user1={data.user1} user2={data.user2} />}
{!loading && !error && !data && (
<div className="flex flex-col items-center justify-center py-20 text-center text-muted-foreground gap-4">
<svg
xmlns="http://www.w3.org/2000/svg"
width="64"
height="64"
viewBox="0 0 24 24"
fill="none"
stroke="currentColor"
strokeWidth="1.5"
strokeLinecap="round"
strokeLinejoin="round"
className="opacity-30"
>
<circle cx="9" cy="7" r="4" />
<circle cx="15" cy="7" r="4" />
<path d="M3 21v-2a4 4 0 0 1 4-4h10a4 4 0 0 1 4 4v2" />
</svg>
<p className="text-lg font-medium">
Enter two usernames to compare
</p>
<p className="text-sm opacity-70">
Compare GitHub developer metrics side by side.
Share the URL to save your comparison.
</p>
</div>
)}
</div>
);
}

export default function HomePage() {
return (
<main className="min-h-screen">
{" "}
<header className="sticky top-0 z-50 w-full border-b bg-background/95 backdrop-blur supports-[backdrop-filter]:bg-background/60">
<div className="container flex h-16 max-w-7xl items-center justify-between m-auto px-4">
<div className="flex items-center gap-2 font-bold text-xl">
<span className="bg-gradient-to-r from-primary to-primary/60 bg-clip-text text-transparent">
DevImpact
</span>
</div>

</div>
</header>
<div className="max-w-6xl mx-auto px-4 py-10 space-y-6">
<CompareForm
onSubmit={handleCompare}
loading={loading}
reset={reset}
swapUsers={swapUsers}
data={data}
/>

{loading && skeleton}
{error && (
<div className="card p-4 text-sm text-red-600 bg-red-50 border border-red-100">
{error}
</div>
)}
{data && <ResultDashboard user1={data.user1} user2={data.user2} />}
{!loading && !error && !data && (
<div className="flex flex-col items-center justify-center py-20 text-center text-muted-foreground gap-4">
<svg
xmlns="http://www.w3.org/2000/svg"
width="64"
height="64"
viewBox="0 0 24 24"
fill="none"
stroke="currentColor"
strokeWidth="1.5"
strokeLinecap="round"
strokeLinejoin="round"
className="opacity-30"
>
<circle cx="9" cy="7" r="4" />
<circle cx="15" cy="7" r="4" />
<path d="M3 21v-2a4 4 0 0 1 4-4h10a4 4 0 0 1 4 4v2" />
</svg>
<p className="text-lg font-medium">Enter two usernames to compare</p>
<p className="text-sm opacity-70">
Compare GitHub developer metrics side by side
</p>
<Suspense
fallback={
<div className="flex items-center justify-center py-20">
<div className="animate-spin h-8 w-8 border-4 border-primary border-t-transparent rounded-full" />
</div>
)}
</div>
}
>
<HomePageContent />
</Suspense>
<footer className="border-t py-6 text-center text-sm text-muted-foreground">
<div className="container max-w-7xl mx-auto px-4">
<span className="font-medium">DevImpact</span> — Compare GitHub developer metrics
Expand Down
25 changes: 21 additions & 4 deletions components/compare-form.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { useState } from "react";
import { useState, useRef, useEffect } from "react";
import { Button } from "./ui/button";
import { ArrowLeftRight, RefreshCw } from "lucide-react";
import {
Expand All @@ -17,6 +17,8 @@ type CompareFormProps = {
reset?: () => void;
swapUsers?: () => void;
error?: string | null;
initialUsername1?: string;
initialUsername2?: string;
};

export function CompareForm({
Expand All @@ -26,9 +28,23 @@ export function CompareForm({
swapUsers,
reset,
error,
initialUsername1 = "pbiggar",
initialUsername2 = "CoralineAda",
}: CompareFormProps) {
const [username1, setUsername1] = useState("pbiggar");
const [username2, setUsername2] = useState("CoralineAda");
const [username1, setUsername1] = useState(initialUsername1 || "pbiggar");
const [username2, setUsername2] = useState(initialUsername2 || "CoralineAda");
const firstInputRef = useRef<HTMLInputElement>(null);

useEffect(() => {
if (initialUsername1) setUsername1(initialUsername1);
if (initialUsername2) setUsername2(initialUsername2);
}, [initialUsername1, initialUsername2]);

useEffect(() => {
if (!initialUsername1) {
firstInputRef.current?.focus();
}
}, [initialUsername1]);

const canSubmit = Boolean(username1.trim() && username2.trim() && !loading);

Expand Down Expand Up @@ -63,13 +79,14 @@ export function CompareForm({
<div className="grid gap-3 md:grid-cols-2">
<input
className="h-11 rounded-lg border border-slate-200 px-3 text-sm focus:outline-none focus:ring-2 focus:ring-primary/60 focus:border-transparent bg-white"
ref={firstInputRef}
placeholder={"Username 1 (e.g., torvalds)"}
value={username1}
onChange={(e) => setUsername1(e.target.value)}
/>
<input
className="h-11 rounded-lg border border-slate-200 px-3 text-sm focus:outline-none focus:ring-2 focus:ring-primary/60 focus:border-transparent bg-white"
placeholder={"Username 2 (e.g., torvalds)"}
placeholder={"Username 2 (e.g., torvalds)"}
value={username2}
onChange={(e) => setUsername2(e.target.value)}
/>
Expand Down