feat: display friendly error messages on API failure#69
Closed
Ai-chan-0411 wants to merge 1 commit intoO2sa:mainfrom
Closed
feat: display friendly error messages on API failure#69Ai-chan-0411 wants to merge 1 commit intoO2sa:mainfrom
Ai-chan-0411 wants to merge 1 commit intoO2sa:mainfrom
Conversation
closes O2sa#34 Add user-friendly error messages when GitHub API calls fail: - ErrorMessage component with error type detection (rate limit/not found/network) - Retry button for transient errors - Replaces generic red error box with proper Alert component Signed-off-by: Ai-chan-0411 <ai-chan-0411@users.noreply.github.com>
|
@Ai-chan-0411 is attempting to deploy a commit to the osama's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
Thank you for the pull request! ✅ A maintainer will review this soon. Please be patient while we take a look. 🙌 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #34
Summary
Replaces the generic red error box with a context-aware
ErrorMessagecomponent that provides actionable feedback based on the type of error.Changes
components/error-message.tsx(new):ErrorMessagecomponent that detects error type (user not found / rate limit / network / generic) and shows an appropriate title + description, with optional retry buttonapp/api/compare/route.ts: Returns specific error messages for rate limit (HTTP 403) and "user not found" cases, instead of a generic fallbackapp/page.tsx: Replaces<div className="card p-4 text-sm text-red-600 ...">with<ErrorMessage>component; minor layout improvements (flex flex-col/flex-1 w-full)Before / After
Before:
Plain red box:
Failed to calculate scoreAfter:
Shadcn
Alert(destructive variant) with icon, descriptive title, and human-readable message: