Fix stale MACsec peer SCI on same-host chain edges - #145
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same-host chain setup keyed its MACsec RX SA by reading the peer veth's MAC.
Since a macsec device inherits its parent veth's MAC, net-id reuse could leave the two passes reading different incarnations of the pair — one side then expects an SCI that no longer exists, and MACsec drops the unmatched frames silently.
The edge goes dead in one direction while the control plane reports it established.
Derives both veth MACs from the net id so each side's SCI is a pure function of
$VXLAN_ID, serializes setup/teardown per net id with a flock, and matches XFRM teardown on SPI/dstport rather than endpoints (which stop describing what setup installed once an id is reissued).Fixes #144