Skip to content

ui: fix Internet Clients list dividers and layout break on multi-net-id chains #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
GyulyVGC merged 2 commits into from
Aug 4, 2026
Merged

ui: fix Internet Clients list dividers and layout break on multi-net-id chains #132

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4dd8901
ui: add row divider to Internet Clients list and fix layout break on …
antoncxx Aug 3, 2026
7a14261
ui: truncate chained net-id lists in Dashboard and EdgePanel
antoncxx Aug 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 13 additions & 6 deletions members/nullnet-server/ui/src/components/topology/EdgePanel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,6 +142,9 @@ export default function EdgePanel({ edges }: Props) {

{edges.map((e, i) => {
const session = sessionByNetId.get(e.net_id);
const netIdsLabel = e.via_proxy && chainByProxyNetId.has(e.net_id)
? `nets ${chainByProxyNetId.get(e.net_id)!.join(', ')}`
: `net ${e.net_id}`;
return (
<div key={i} style={{
background: 'rgba(255,255,255,.03)',
Expand All @@ -150,14 +153,18 @@ export default function EdgePanel({ edges }: Props) {
padding: '9px 11px',
marginBottom: 6,
}}>
<div style={{ display: 'flex', justifyContent: 'space-between', alignItems: 'center', marginBottom: session || e.via_proxy || e.egress ? 6 : 0 }}>
<span style={{ fontFamily: "'JetBrains Mono',monospace", fontSize: 10, color: 'var(--cyan)' }}>
{e.via_proxy && chainByProxyNetId.has(e.net_id)
? `nets ${chainByProxyNetId.get(e.net_id)!.join(', ')}`
: `net ${e.net_id}`}
<div style={{ display: 'flex', justifyContent: 'space-between', alignItems: 'center', gap: 8, marginBottom: session || e.via_proxy || e.egress ? 6 : 0 }}>
<span
title={netIdsLabel}
style={{
fontFamily: "'JetBrains Mono',monospace", fontSize: 10, color: 'var(--cyan)',
flex: 1, minWidth: 0, overflow: 'hidden', textOverflow: 'ellipsis', whiteSpace: 'nowrap',
}}
>
{netIdsLabel}
</span>
{e.setup_ms > 0 && (
<span style={{ fontSize: 10, color: 'var(--t2)' }}>{e.setup_ms}ms setup</span>
<span style={{ fontSize: 10, color: 'var(--t2)', flexShrink: 0 }}>{e.setup_ms}ms setup</span>
)}
</div>
{e.egress && (
Expand Down
17 changes: 12 additions & 5 deletions members/nullnet-server/ui/src/components/topology/InternetPanel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,8 @@ export default function InternetPanel() {

{sessionList.map(s => {
const isFocused = focusedClientIp === s.client_ip;
const netIds = chainByProxyNetId.get(s.network_id);
const netIdsLabel = netIds ? `nets ${netIds.join(', ')}` : `net ${s.network_id}`;
return (
<div
key={s.id}
Expand All @@ -54,6 +56,7 @@ export default function InternetPanel() {
marginBottom: 2,
borderRadius: 5,
border: `1px solid ${isFocused ? 'rgba(91,156,246,.45)' : 'transparent'}`,
borderBottom: isFocused ? undefined : '1px solid var(--t3)',
background: isFocused ? 'rgba(91,156,246,.08)' : 'transparent',
cursor: 'pointer',
transition: 'background .12s, border-color .12s',
Expand All @@ -71,11 +74,15 @@ export default function InternetPanel() {
{s.service}{s.org ? ` · ${s.org}` : ''}
</div>
</div>
<div style={{ flexShrink: 0, textAlign: 'right' }}>
<div style={{ fontSize: 9.5, fontFamily: "'JetBrains Mono',monospace", color: 'var(--cyan)' }}>
{chainByProxyNetId.has(s.network_id)
? `nets ${chainByProxyNetId.get(s.network_id)!.join(', ')}`
: `net ${s.network_id}`}
<div style={{ flexShrink: 0, textAlign: 'right', maxWidth: 110 }}>
<div
title={netIdsLabel}
style={{
fontSize: 9.5, fontFamily: "'JetBrains Mono',monospace", color: 'var(--cyan)',
overflow: 'hidden', textOverflow: 'ellipsis', whiteSpace: 'nowrap',
}}
>
{netIdsLabel}
</div>
<div style={{ fontSize: 9, color: 'var(--t2)' }}>{formatTime(s.created_at)}</div>
</div>
Expand Down
12 changes: 9 additions & 3 deletions members/nullnet-server/ui/src/pages/Dashboard.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,6 +119,9 @@ function DashboardView() {
<tbody>
{graph!.edges.map((e, i) => {
const session = sessionByNetId.get(e.net_id);
const netIdsLabel = e.via_proxy && chainByProxyNetId.has(e.net_id)
? chainByProxyNetId.get(e.net_id)!.join(', ')
: String(e.net_id);
return (
<tr
key={i}
Expand All @@ -136,9 +139,12 @@ function DashboardView() {
</td>
<td style={{ fontFamily: "'JetBrains Mono',monospace", fontWeight: 500 }}>{e.to}</td>
<td style={{ fontFamily: "'JetBrains Mono',monospace", color: 'var(--cyan)' }}>
{e.via_proxy && chainByProxyNetId.has(e.net_id)
? chainByProxyNetId.get(e.net_id)!.join(', ')
: e.net_id}
<div
title={netIdsLabel}
style={{ maxWidth: 130, overflow: 'hidden', textOverflow: 'ellipsis', whiteSpace: 'nowrap' }}
>
{netIdsLabel}
</div>
</td>
<td style={{ fontFamily: "'JetBrains Mono',monospace", fontSize: 11, color: 'var(--t1)' }}>
{session?.client_net ?? <span style={{ color: 'var(--t3)' }}>—</span>}
Expand Down