conform: respect vim.lsp.formatOnSave and vim.lsp.mappings.toggleFormatOnSave - #891
Merged
NotAShelf merged 5 commits intoMay 9, 2025
Merged
Conversation
horriblename
changed the title
horriblename
changed the title
NotAShelf
reviewed
May 9, 2025
NotAShelf
left a comment
NotAShelf
left a comment
Owner
There was a problem hiding this comment.
Could you add a quick CHANGELOG entry for this? Not a breaking change, but should be communicated more clearly imo.
horriblename
marked this pull request as draft
May 9, 2025 02:10
horriblename
force-pushed
the
conform-format-on-save-fix-v2
branch
from
May 9, 2025 02:12
fb00f60 to
9b505ab
Compare
horriblename
force-pushed
the
conform-format-on-save-fix-v2
branch
from
May 9, 2025 02:13
9b505ab to
955f204
Compare
Collaborator
Author
|
by CHANGELOG you mean release notes right? |
horriblename
marked this pull request as ready for review
May 9, 2025 02:17
Owner
|
Yes, sorry I'm a little tired. Just a regular entry as we usually add them. |
NotAShelf
approved these changes
May 9, 2025
|
✅ Preview has been deleted successfully! |
This was referenced May 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
supersedes #768