Skip to content

utility/jupynvim: init - #1787

Open
jack-thesparrow wants to merge 10 commits into
NotAShelf:mainfrom
jack-thesparrow:feat/jupynvim
Open

utility/jupynvim: init#1787
jack-thesparrow wants to merge 10 commits into
NotAShelf:mainfrom
jack-thesparrow:feat/jupynvim

Conversation

@jack-thesparrow

@jack-thesparrow jack-thesparrow commented Aug 16, 2026

Copy link
Copy Markdown

Sanity Checking

  • I have updated the changelog as per my changes
  • I have tested, and self-reviewed my code
  • My changes fit guidelines found in hacking nvf
  • Style and consistency
    • I ran Alejandra to format my code (nix fmt)
    • My code conforms to the editorconfig configuration of the project
    • My changes are consistent with the rest of the codebase
  • If new changes are particularly complex:
    • My code includes comments in particularly complex areas
    • I have added a section in the manual
    • I have included a migration guide
  • Package(s) built:
    • .#nix
    • .#maximal
    • .#docs-html
    • .#docs-linkcheck
  • Tested on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin

Add jupyter-notebook interface made with rust
@github-actions

github-actions Bot commented Aug 16, 2026

Copy link
Copy Markdown

🚀 Live preview deployed from c5cad7e

View it here:

Debug Information

Triggered by: jack-thesparrow

HEAD at: feat/jupynvim

Reruns: 3984

Comment thread flake/pkgs/by-name/jupynvim/package.nix Outdated
Split the Rust backend out of the plugin's package.nix into a standalone
flake/pkgs/by-name/jupynvim-core package so it can be reused and
overridden independently of the Lua frontend.
github-actions Bot pushed a commit that referenced this pull request Aug 16, 2026
github-actions Bot pushed a commit that referenced this pull request Aug 17, 2026
github-actions Bot pushed a commit that referenced this pull request Aug 17, 2026

@NotAShelf NotAShelf left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some minor comments. Typically we expect plugins to expose options that take to 3rd party tools, e.g, something like chafa_path in the setup table which we can use to allow overriding. If not, this should be brought up with upstream. If such an option exists, please prefer it over adding packages to the closure.

Comment thread flake/pkgs/by-name/jupynvim-core/package.nix Outdated
Comment thread flake/pkgs/by-name/jupynvim/package.nix Outdated
Comment thread modules/plugins/utility/jupynvim/config.nix Outdated
- jupynvim-core: use sourceRoot to point at the core subdirectory
- jupynvim: install the backend binary with install -Dm755
- jupynvim: drop imagemagick/chafa from extraPackages as upstream
  offers no path override for these tools

@jack-thesparrow jack-thesparrow left a comment

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done with the changes.

Comment thread configuration.nix Outdated
Comment thread flake/pkgs/by-name/jupynvim-core/package.nix
Comment thread modules/plugins/utility/jupynvim/jupynvim.nix Outdated
Comment thread modules/plugins/utility/jupynvim/config.nix Outdated
github-actions Bot pushed a commit that referenced this pull request Aug 19, 2026
@NotAShelf

Copy link
Copy Markdown
Owner

@jack-thesparrow I'd like a disclosure on how LLMs were used in this PR. It is no longer a question they were used, but a question of how they were used. While we don't have a clear LLM policy; I cannot, in good faith, merge a PR where the author has put their agent on the task of responding to review comments. This is disrespectful to both my co-maintainers, who have gracefully taken time of their day to review, and the users who expect us to deliver quality.

@jack-thesparrow

Copy link
Copy Markdown
Author

@jack-thesparrow I'd like a disclosure on how LLMs were used in this PR. It is no longer a question they were used, but a question of how they were used. While we don't have a clear LLM policy; I cannot, in good faith, merge a PR where the author has put their agent on the task of responding to review comments. This is disrespectful to both my co-maintainers, who have gracefully taken time of their day to review, and the users who expect us to deliver quality.

I understand it now sir, and i sincerely apologize for it. I accept that i have used LLMs in this PR and have accepted the changes personally into the PR after checking them. I am sorry to hurt your sentiments. I use NVF as my personal config, so i thought of contributing. I love this project and will still contribute to it, but next time it will be written by me.I have learned my lesson and i am ready to accept your decision on whether to merge or not @NotAShelf :)

github-actions Bot pushed a commit that referenced this pull request Aug 19, 2026
@snoweuph

Copy link
Copy Markdown
Collaborator

@jack-thesparrow I'd like a disclosure on how LLMs were used in this PR. It is no longer a question they were used, but a question of how they were used. While we don't have a clear LLM policy; I cannot, in good faith, merge a PR where the author has put their agent on the task of responding to review comments. This is disrespectful to both my co-maintainers, who have gracefully taken time of their day to review, and the users who expect us to deliver quality.

I understand it now sir, and i sincerely apologize for it. I accept that i have used LLMs in this PR and have accepted the changes personally into the PR after checking them. I am sorry to hurt your sentiments. I use NVF as my personal config, so i thought of contributing. I love this project and will still contribute to it, but next time it will be written by me.I have learned my lesson and i am ready to accept your decision on whether to merge or not @NotAShelf :)

You seem to not have understood the main point. Its the same as in #1778
Its about disclosure in which way and context it was used.

@snoweuph

snoweuph commented Aug 19, 2026

Copy link
Copy Markdown
Collaborator

@jack-thesparrow I'd like a disclosure on how LLMs were used in this PR. It is no longer a question they were used, but a question of how they were used. While we don't have a clear LLM policy; I cannot, in good faith, merge a PR where the author has put their agent on the task of responding to review comments. This is disrespectful to both my co-maintainers, who have gracefully taken time of their day to review, and the users who expect us to deliver quality.

I understand it now sir, and i sincerely apologize for it. I accept that i have used LLMs in this PR and have accepted the changes personally into the PR after checking them. I am sorry to hurt your sentiments. I use NVF as my personal config, so i thought of contributing. I love this project and will still contribute to it, but next time it will be written by me.I have learned my lesson and i am ready to accept your decision on whether to merge or not @NotAShelf :)

You seem to not have understood the main point. Its same as in #1778 Its about disclosure in which way and context it was used.
This is the last reminder: disclose us HOW and for WHAT LLMs where used and in which capacity

@jack-thesparrow

Copy link
Copy Markdown
Author

@jack-thesparrow I'd like a disclosure on how LLMs were used in this PR. It is no longer a question they were used, but a question of how they were used. While we don't have a clear LLM policy; I cannot, in good faith, merge a PR where the author has put their agent on the task of responding to review comments. This is disrespectful to both my co-maintainers, who have gracefully taken time of their day to review, and the users who expect us to deliver quality.

I understand it now sir, and i sincerely apologize for it. I accept that i have used LLMs in this PR and have accepted the changes personally into the PR after checking them. I am sorry to hurt your sentiments. I use NVF as my personal config, so i thought of contributing. I love this project and will still contribute to it, but next time it will be written by me.I have learned my lesson and i am ready to accept your decision on whether to merge or not @NotAShelf :)

You seem to not have understood the main point. Its same as in #1778 Its about disclosure in which way and context it was used. This is the last reminder: disclose us HOW and for WHAT LLMs where used and in which capacity

I used LLMs it to write grep commands to skim through the existing codebase to learn how existing plugins were implemented, for writing the default keybinds, and replying to the Github reviews.

github-actions Bot pushed a commit that referenced this pull request Aug 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants