utility/jupynvim: init - #1787
Conversation
Add jupyter-notebook interface made with rust
Split the Rust backend out of the plugin's package.nix into a standalone flake/pkgs/by-name/jupynvim-core package so it can be reused and overridden independently of the Lua frontend.
NotAShelf
left a comment
There was a problem hiding this comment.
I left some minor comments. Typically we expect plugins to expose options that take to 3rd party tools, e.g, something like chafa_path in the setup table which we can use to allow overriding. If not, this should be brought up with upstream. If such an option exists, please prefer it over adding packages to the closure.
- jupynvim-core: use sourceRoot to point at the core subdirectory - jupynvim: install the backend binary with install -Dm755 - jupynvim: drop imagemagick/chafa from extraPackages as upstream offers no path override for these tools
jack-thesparrow
left a comment
There was a problem hiding this comment.
Done with the changes.
|
@jack-thesparrow I'd like a disclosure on how LLMs were used in this PR. It is no longer a question they were used, but a question of how they were used. While we don't have a clear LLM policy; I cannot, in good faith, merge a PR where the author has put their agent on the task of responding to review comments. This is disrespectful to both my co-maintainers, who have gracefully taken time of their day to review, and the users who expect us to deliver quality. |
I understand it now sir, and i sincerely apologize for it. I accept that i have used LLMs in this PR and have accepted the changes personally into the PR after checking them. I am sorry to hurt your sentiments. I use NVF as my personal config, so i thought of contributing. I love this project and will still contribute to it, but next time it will be written by me.I have learned my lesson and i am ready to accept your decision on whether to merge or not @NotAShelf :) |
You seem to not have understood the main point. Its the same as in #1778 |
You seem to not have understood the main point. Its same as in #1778 Its about disclosure in which way and context it was used. |
I used LLMs it to write grep commands to skim through the existing codebase to learn how existing plugins were implemented, for writing the default keybinds, and replying to the Github reviews. |
Sanity Checking
nix fmt).#nix.#maximal.#docs-html.#docs-linkcheckx86_64-linuxaarch64-linuxx86_64-darwinaarch64-darwin