Skip to content

Factor out Formatters#1646

Open
snoweuph wants to merge 104 commits into
NotAShelf:mainfrom
snoweuph:feat/formatters
Open

Factor out Formatters#1646
snoweuph wants to merge 104 commits into
NotAShelf:mainfrom
snoweuph:feat/formatters

Conversation

@snoweuph

@snoweuph snoweuph commented Jun 13, 2026

Copy link
Copy Markdown
Collaborator

Needs: #1649
Closes: #1576

Sanity Checking

  • I have updated the changelog as per my changes
  • I have tested, and self-reviewed my code
  • My changes fit guidelines found in hacking nvf
  • Style and consistency
    • I ran Alejandra to format my code (nix fmt)
    • My code conforms to the editorconfig configuration of the project
    • My changes are consistent with the rest of the codebase
  • If new changes are particularly complex:
    • My code includes comments in particularly complex areas
    • I have added a section in the manual
    • (For breaking changes) I have included a migration guide
  • Package(s) built:
    • .#nix (default package)
    • .#maximal
    • .#docs-html (manual, must build)
    • .#docs-linkcheck (optional, please build if adding links)
  • Tested on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin

Add a 👍 reaction to pull requests you find important.

@github-actions

github-actions Bot commented Jun 13, 2026

Copy link
Copy Markdown

🚀 Live preview deployed from 079b221

View it here:

Debug Information

Triggered by: snoweuph

HEAD at: feat/formatters

Reruns: 3412

@snoweuph snoweuph changed the title Feat/formatters Factor out Formatters Jun 13, 2026
@snoweuph snoweuph added this to the 0.9 milestone Jun 13, 2026
github-actions Bot pushed a commit that referenced this pull request Jun 14, 2026
@snoweuph snoweuph force-pushed the feat/formatters branch 7 times, most recently from 50f9c56 to 32e00e8 Compare June 14, 2026 12:50

@horriblename horriblename left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lookks good overall, small minor nits

Comment thread modules/plugins/formatter/conform-nvim/presets/prettier.nix Outdated
Comment thread modules/plugins/formatter/conform-nvim/presets/prettier.nix
Comment thread modules/plugins/formatter/conform-nvim/presets/stylua.nix Outdated
github-actions Bot pushed a commit that referenced this pull request Jun 14, 2026
@snoweuph snoweuph force-pushed the feat/formatters branch 6 times, most recently from c51cde7 to cd868be Compare June 14, 2026 18:44
github-actions Bot pushed a commit that referenced this pull request Jun 14, 2026
@snoweuph snoweuph force-pushed the feat/formatters branch 3 times, most recently from 88a5b34 to a961998 Compare June 15, 2026 15:25
github-actions Bot pushed a commit that referenced this pull request Jun 15, 2026
@snoweuph snoweuph force-pushed the feat/formatters branch 2 times, most recently from a341e77 to c7962a0 Compare June 19, 2026 02:45
snoweuph added 29 commits July 2, 2026 20:21
@snoweuph

snoweuph commented Jul 2, 2026

Copy link
Copy Markdown
Collaborator Author

forwarded, as #1649 is merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Factor out Formatters and Diagnostics into Presets

2 participants