Fixed StringSubstring() case where the result is one character returns NULL#279
Open
craigcomstock wants to merge 1 commit into
Open
Fixed StringSubstring() case where the result is one character returns NULL#279craigcomstock wants to merge 1 commit into
craigcomstock wants to merge 1 commit into
Conversation
…s NULL Ticket: none Changelog: none
|
There was an error running your pipeline, see logs for details. |
olehermanse
reviewed
Jun 22, 2026
Comment on lines
+372
to
+378
| static void test_substring_result_is_one_char(void) | ||
| { | ||
| char *new_string = StringSubstring("[1]", 3, 1, -1); | ||
| assert_string_equal(new_string, "1"); | ||
| free(new_string); | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
Cool, but let's maybe add a few more tests to be sure? I.e. what happens when the 1 char string is at the beginning or end? What happens when the input string is also 1 character? What about when the input or the result is 0 length?
olehermanse
requested changes
Jun 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket: none
Changelog: none