Skip to content

#4317 rules car filtering - #4358

Open
cielbellerose wants to merge 6 commits into
feature/rules-dashboardfrom
#4317-rules-car-filtering
Open

#4317 rules car filtering#4358
cielbellerose wants to merge 6 commits into
feature/rules-dashboardfrom
#4317-rules-car-filtering

Conversation

@cielbellerose

@cielbellerose cielbellerose commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Changes

car filtering for rulesets

Test Cases

Instead of one active ruleset per ruleset type -> one active ruleset per type per car
(since a project is connected to a car and we only want one ruleset to show up per type in the project rules view)

  • Successful get rulesets by ruleset types filtered by car, and all rulesets when all cars selected
  • Two active rulesets can be set for a type if they are for different cars
  • Cannot create two active for the same car
  • fails if car doesnt exist
  • get active ruleset gets the correct ruleset for specified car when two are active

FSAE_2027 showed up for a project connected to the NER-25 car, and Mock_FSAE correctly showed up for a Fergus project

Screenshots

Screenshot 2026-07-30 at 9 58 21 PM Screenshot 2026-07-30 at 9 58 31 PM Screenshot 2026-07-30 at 9 58 41 PM Screenshot 2026-07-30 at 10 20 41 PM

Checklist

It can be helpful to check the Checks and Files changed tabs.
Please review the contributor guide and reach out to your Tech Lead if anything is unclear.
Please request reviewers and ping on slack only after you've gone through this whole checklist.

  • All commits are tagged with the ticket number
  • No linting errors / newline at end of file warnings
  • All code follows repository-configured prettier formatting
  • No merge conflicts
  • All checks passing
  • Screenshots of UI changes (see Screenshots section)
  • Remove any non-applicable sections of this template
  • Assign the PR to yourself
  • No yarn.lock changes (unless dependencies have changed)
  • Request reviewers & ping on Slack
  • PR is linked to the ticket (fill in the closes line below)

Closes #4317

@cielbellerose cielbellerose self-assigned this Jul 30, 2026
@cielbellerose cielbellerose linked an issue Jul 30, 2026 that may be closed by this pull request
2 tasks
@cielbellerose
cielbellerose changed the base branch from develop to feature/rules-dashboard July 30, 2026 21:01
@cielbellerose
cielbellerose marked this pull request as ready for review July 30, 2026 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[RulesDashboard] - Add Car Filtering to Rules Dash

1 participant