4218-uploads-not-displaying-on-parts-review-page clear stale files state when part form modals close

[RemainingDelta]

Changes

Fixed a bug in SubmissionFormModal and ReviewFormModal where uploaded file names would not appear after form submission. NERFormModal resets the RHF fileIdsfield array on every close, but the parallel local files: File[] state was never cleared. On re-open, the length mismatch caused the file list to not render. Added a useEffect in both modals that resets files (and selectedPartIndex in ReviewFormModal) whenever open becomes false.

Test Cases

• Repeat several times to ensure the fix works
  • Upload files in New Submission modal (Projects -> Specific Project -> Part Review -> New -> New Submission) — file names appear in the list
  • Submit the form, re-open New Submission — file list is empty with no stale entries
  • Upload a new file on re-open — correct file name appears

Screenshots

Before

Note: This sometimes happens, not always
A file is uploaded, but it doesn't show file name

After

A file is uploaded, but it always shows file name:

Closes #4218

[staysgt]

Good job!

[wavehassman]

Great job fixing the bug! I would just prefer it to be structured differently

[wavehassman]

Instead of a useEffect in both files, just wrap handleClose in a callback that also clears the state. Then update the onHide= call. It should look something like this:

const handleCloseAndReset = () => {
  setFiles([]);
  setSelectedPartIndex(undefined); 
  handleClose();
};