Hardhat 3 migration follow-ups - #4
Open
schaable wants to merge 4 commits into
Open
Conversation
…dant by npmFilesToBuild
… arbitrum migrate configs
…y the hardhat 3 migration
There was a problem hiding this comment.
Pull request overview
This PR contains small follow-ups for the Hardhat 3 migration across the monorepo, removing a prior Hardhat 2 artifact-generation workaround and aligning migration configs and repo hygiene with the new setup.
Changes:
- Removed the
imports.solmock workaround and the associated Foundry ignore entry (Hardhat config already explicitly builds the OZ proxy contracts vianpmFilesToBuild). - Added
recurringCollectorAddressto the Arbitrum One and Arbitrum Sepolia SubgraphService migration configs, plus a changeset noting the fix. - Cleaned up repo-level tooling noise by dropping retired
hardhat-network gitignore patterns and pruning unused pnpm catalog entries.
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| pnpm-workspace.yaml | Prunes unused catalog entries to keep workspace dependency catalog minimal. |
| packages/subgraph-service/ignition/configs/migrate.arbitrumSepolia.json5 | Adds recurringCollectorAddress to unblock Arbitrum Sepolia migration step config. |
| packages/subgraph-service/ignition/configs/migrate.arbitrumOne.json5 | Adds recurringCollectorAddress to unblock Arbitrum One migration step config. |
| packages/horizon/foundry.toml | Removes ignore entry that only existed for the now-deleted imports.sol. |
| packages/horizon/contracts/mocks/imports.sol | Deletes the retired Hardhat 2 artifact workaround file. |
| .gitignore | Removes ignore patterns tied to the retired hardhat network name. |
| .changeset/tall-geese-argue.md | Records a patch release note for the subgraph-service config fix. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
imports.sol, a hardhat 2 artifact-generation workaroundhardhatnetwork name