Skip to content

#821 Migrate PhotoCapture component#1

Closed
NoelDeMartin wants to merge 4 commits into
835-documentationfrom
821-photo-capture
Closed

#821 Migrate PhotoCapture component#1
NoelDeMartin wants to merge 4 commits into
835-documentationfrom
821-photo-capture

Conversation

@NoelDeMartin

@NoelDeMartin NoelDeMartin commented Jul 9, 2026 •
edited
Loading

Copy link
Copy Markdown
Owner

No description provided.

@NoelDeMartin NoelDeMartin linked an issue Jul 9, 2026 that may be closed by this pull request
Photo Capture Web component SolidOS/solid-ui#821
Open
@NoelDeMartin NoelDeMartin mentioned this pull request Jul 9, 2026
Open
@NoelDeMartin
NoelDeMartin force-pushed the 821-photo-capture branch 2 times, most recently from 715e720 to 2d9ea7c Compare July 15, 2026 08:24
@NoelDeMartin
NoelDeMartin changed the base branch from improvements to 835-documentation July 15, 2026 08:24
@NoelDeMartin
NoelDeMartin force-pushed the 821-photo-capture branch 3 times, most recently from 73209f9 to dbf345c Compare July 15, 2026 10:21
@NoelDeMartin
NoelDeMartin force-pushed the 821-photo-capture branch 3 times, most recently from bfbd6d0 to eb26730 Compare July 16, 2026 10:35
@NoelDeMartin NoelDeMartin mentioned this pull request Jul 16, 2026
Merged
timea-solid
timea-solid approved these changes Jul 18, 2026
View reviewed changes
Comment thread src/components/photo-capture/PhotoCapture.ts Outdated
Comment thread src/components/photo-capture/PhotoCapture.test.ts Outdated
@NoelDeMartin
Merge pull request SolidOS#839 from NoelDeMartin/835-documentation
0fcec65 
SolidOS#835 Improve documentation and ergonomics
@NoelDeMartin
SolidOS#821 Implement reusable FormControlComponent
3cd9fbe
@NoelDeMartin
SolidOS#821 Migrate PhotoCapture component
42e449f 
This is a first pass towards modernizing this component, but it can still be improved further to use newer Dialog System.

The tests were removed because the new form handling relies on ElementInternals api (it was optional before), but it isn't availble in the test environment.

Also removed some inline comments about attribution, leaving them here for documentation purposes:

> The original code was written by Sir Tim Berners-Lee. It was made into a web component by AI Model GPT-5.4
>
> Prompt: Take the code from src/media/media-capture.ts and make it a web component. Make it work in forms as well as not. Make it configurable and follow LoginButton.
@NoelDeMartin
SolidOS#821 Migrate PhotoCapture internals to Dialog System
6c70a76 
This change actually refactors the intended usage of the PhotoCapture component, and gets rid of many features that weren't used or necessary:

- Now it only supports the "dialog" mode, this is no longer configurable.
- All events have been removed in favour of the native `input` event. This should be fine since the component should be used as a standard FormControl.
- Theme configuration has been removed, given that dark mode hasn't been implemented in the Design System yet. Even when it does, it probably should be something that can be changed with a property.
- Replaced the standard trigger overriding with a standard trigger slot (also used in LoginButton, LogoutButton, etc.).
- Removed some properties that are no longer applicable: `autoCloseOnCapture`, `showTrigger`, `theme`, `presentation`, and `open`.
@NoelDeMartin

NoelDeMartin commented Jul 18, 2026

Copy link
Copy Markdown
Owner Author

Moved to SolidOS#840

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@timea-solid timea-solid timea-solid approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Photo Capture Web component

2 participants

@NoelDeMartin @timea-solid