Fix/401 404 exit

[alexphelps]

No description provided.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

[kilo-code-bot]

Code Review Summary

Status: 5 Issues Found | Recommendation: Address before merge

Overview

Severity	Count
CRITICAL	1
WARNING	3
SUGGESTION	1

Issue Details (click to expand)

CRITICAL

File	Line	Issue
ntk/gateway.py	20	Unbounded recursion on persistent ConnectionError — will stack-overflow instead of reporting a network failure cleanly.

WARNING

File	Line	Issue
ntk/gateway.py	19	Only ConnectionError is caught; Timeout/SSLError/ChunkedEncodingError still propagate.
ntk/decorator.py	42	sys.exit(1) from library decorator kills callers (notably ntk watch) and prevents unit-testing.
ntk/decorator.py	46	Generic 404 message can't distinguish missing-theme from missing-endpoint / wrong store URL.

SUGGESTION

File	Line	Issue
ntk/decorator.py	40	Fold 401/404 into the existing error-format branch instead of short-circuiting with sys.exit.

Files Reviewed (3 files)

• ntk/gateway.py - 2 issues
• ntk/decorator.py - 3 issues
• README.md - 0 issues (doc-only revert, no code defects)

Fix these issues in Kilo Cloud

Previous Review Summaries (2 snapshots, latest commit cd3bf7d)

Current summary above is authoritative. Previous snapshots are kept for context only.

Previous review (commit cd3bf7d)

Status: 5 Issues Found | Recommendation: Address before merge

Overview

Severity	Count
CRITICAL	1
WARNING	3
SUGGESTION	1

Issue Details (click to expand)

CRITICAL

File	Line	Issue
ntk/gateway.py	20	Unbounded recursion on persistent ConnectionError — will stack-overflow instead of reporting a network failure cleanly.

WARNING

File	Line	Issue
ntk/gateway.py	19	Only ConnectionError is caught; Timeout/SSLError/ChunkedEncodingError still propagate.
ntk/decorator.py	42	sys.exit(1) from library decorator kills callers (notably ntk watch) and prevents unit-testing.
ntk/decorator.py	46	Generic 404 message can't distinguish missing-theme from missing-endpoint / wrong store URL.

SUGGESTION

File	Line	Issue
ntk/decorator.py	40	Fold 401/404 into the existing error-format branch instead of short-circuiting with sys.exit.

Files Reviewed (3 files)

• ntk/gateway.py - 2 issues
• ntk/decorator.py - 3 issues
• README.md - 0 issues (doc-only revert, no code defects)

Fix these issues in Kilo Cloud

Previous review (commit 55f4eff)

Status: 5 Issues Found | Recommendation: Address before merge

Overview

Severity	Count
CRITICAL	1
WARNING	3
SUGGESTION	1

Issue Details (click to expand)

CRITICAL

File	Line	Issue
ntk/gateway.py	20	Unbounded recursion on persistent ConnectionError — will stack-overflow instead of reporting a network failure cleanly.

WARNING

File	Line	Issue
ntk/gateway.py	19	Only ConnectionError is caught; Timeout/SSLError/ChunkedEncodingError still propagate.
ntk/decorator.py	42	sys.exit(1) from library decorator kills callers (notably ntk watch) and prevents unit-testing.
ntk/decorator.py	46	Generic 404 message can't distinguish missing-theme from missing-endpoint / wrong store URL.

SUGGESTION

File	Line	Issue
ntk/decorator.py	40	Fold 401/404 into the existing error-format branch instead of short-circuiting with sys.exit.

Files Reviewed (3 files)

• ntk/gateway.py - 2 issues
• ntk/decorator.py - 3 issues
• README.md - 0 issues (doc-only revert, no code defects)

Fix these issues in Kilo Cloud

---

_{Reviewed by minimax-m3 · Input: 58.1K · Output: 2.7K · Cached: 347.1K}