fix(ns-api): improve ns.ha API - #1864
Closed
gsanchietti wants to merge 2 commits into
Closed
Conversation
The timezone post-commit hook passed the UCI timezone value through "sh -c echo '<value>' > /tmp/TZ", so a value containing a single quote broke out of the quoting and the rest was executed as a command. Write the file directly with Python instead: no shell is involved, and the resulting content is unchanged. Assisted-by: Claude Code:claude-opus-5[1m]
Sanitize JSON payloads sent to the HA peer and validate all HA API parameters before use. Also handle validation errors in the CLI dispatcher instead of crashing. Assisted-by: Claude Code:claude-opus-5[1m]
gsanchietti
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
packages/ns-api/files/ns.hawhere a JSON payload was passed unescaped to a remote shell.packages/ns-api/files/post-commit/update-timezone.py.Test plan
Tested live on two NethSecurity 8.8.0 devices configured as an HA pair.