feat: add optional completed filter to GET /tasks/ endpoint#19
Merged
Merged
Conversation
- Add optional `completed` query param to the GET /tasks/ route - Update `get_tasks` CRUD function to filter by completion status - Closes Navashub#3
Owner
|
Great work @de9pk - this is a clean, focused PR that hits every requirement in Issue #3. The implementation correctly handles all three cases (completed=true, completed=false, no param), the filter composes correctly with the existing pagination, and I appreciate that you kept the query object pattern (query = db.query(...) then conditionally filter) rather than duplicating code. Branch name, commit prefix, and closing the issue via Closes #3 in the description - all done right. Merging now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements Issue #3 — adds an optional
completedquery parameter toGET /tasks/to filter tasks by their completion status.Changes
crud.pyfrom typing import Optionalimportget_tasks()to accept an optionalcompleted: Optional[bool] = Noneparametercompletedis provided, the query filters tasks whereTask.completed == completedrouters/tasks.pyOptionalto importscompleted: Optional[bool] = Nonequery parameter to theGET /tasks/endpointcompletedvalue tocrud.get_tasks()Usage
Closes #3