Skip to content

feat: add pagination to task and user list endpoints#18

Merged
Navashub merged 1 commit into
Navashub:mainfrom
cgb102000:feature/add-pagination
Jun 30, 2026
Merged

feat: add pagination to task and user list endpoints#18
Navashub merged 1 commit into
Navashub:mainfrom
cgb102000:feature/add-pagination

Conversation

@cgb102000

Copy link
Copy Markdown

Changes
Added skip and limit to GET /tasks/
Added skip and limit to GET /users/
Passed the pagination values through the CRUD layer
Applied pagination with SQLAlchemy offset/limit
Updated the README endpoint documentation

Testing
Verified locally with:
python -m unittest discover -s tests -v

@Navashub

Copy link
Copy Markdown
Owner

Great work @cgb102000 - this is exactly how a focused PR should look. 🎉
Verified against Issue #5:

skip/limit added correctly to both GET /tasks/ and GET /users/ with the right defaults (skip=0, limit=10)
Values passed through cleanly to the CRUD layer
offset(skip).limit(limit) applied correctly in both crud.py functions
README updated to document the new query params
Single commit, branch name matches the issue, PR description matches the actual diff - nice discipline here, especially compared to #17. This is the standard going forward.

Merging now. Thanks for the clean contribution, and appreciate you splitting the pagination work out into its own PR.

@Navashub Navashub merged commit d5d1c22 into Navashub:main Jun 30, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants