CHP Expansion - #701
Closed
Bill-Becker wants to merge 59 commits into
Closed
Conversation
… added to REopt.jl
- Remove old deployment files and dependencies. Some of these were even from older setups no longer used. - Try to begin work on cleaning up configuration approach to make things easier to configure via environment variables. The previous approach had several layers of legacy approaches that had built up over time. There was also a lot of duplicate config where there were subtle drifts in configuration that this attempts to de-duplicate and unify. None of this is actually hooked up yet, this is just the beginnings of trying to work on new deployments.
Fixes various syntax errors and missing imports. Also renames `keys.py` to `keys_env.py` just so we don't end up conflicting with people's existing `keys.py` that was gitinored previously. Also sets up docker to use optional `.env` files which should simplify the setup instructions and migration for existing users with custom keys.py files.
This leverages GitHub Actions, along with other changes we've adopted, like Vault for secrets, Pkl for Kubernetes configuration management, and Carvel for deployments. This also removes some areas that I believe are now unused, like the nginx proxy layer, since it doesn't seem like that was previously being used in production any longer.
Since these values were output in the metadata's own output, GitHub Actions would fail, since it would prevent the metadata's output from occurring since it thought it contained masked secrets.
This appears to be an existing staging issue, but it looks like django keeps bumping into this limit and restarting workers inside the container.
This brings back the restart job that used to be implemented in Jenkins.
While this is a bit funky to shoehorn this into this Python app, we have other components of our deployment process that use this library to provide easy database restores, so by leveraging this library, this is the easiest way to integrate that process with this app.
Since this is an optional container only used in local development, shift it to a profile so that it doesn't start by default. This container will only work for NLR developers, so we don't want it starting/building by default in the CI environment or for other users.
Also update the nojulia docker compose variant to align with the main docker compose file that uses the default postgres superuser now (to better align with other environments).
If the user doesn't have CREATE privileges at the database level, then even if the schema already exists, the `CREATE SCHEMA IF NOT EXISTS` will fail.
Align everything on the `reopt` database name as the default. This matches the other `DB_NAME` environment variables being passed into the Celery and Django containers.
PostgreSQL v18 updates; Database restores
Move to GitHub Actions for deployments; other deployment updates/cleanup
Part of the larger, manual rollout of the deployment changes in #714
Reenable staging deploys after dry-run tests
Part of the larger, manual rollout of the deployment changes in #714
Reenable production deploys after dry-run tests
Remove the duplicative nrel.gov ingress now that everything with developer.nlr.gov is cutover to use the nlr.gov ingress.
Remove nrel.gov ingress
This was a copy-paste issue from staging, but the production variable name differs.
Fix ingress to set explicit host for production ingress
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce?
(Bug fix, feature, docs update, ...)
What is the current behavior?
(You can also link to an open issue here)
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change?
(What changes might users need to make in their application due to this PR?)
Other information: