Convert CBECS processor to polars - #461
Open
eringold wants to merge 1 commit into
Open
Conversation
Collaborator
Author
|
existing (refactored) test passes, and I have an 'old vs new' test comparing each value from each col that also passes - happy to share for review. |
ChristopherCaradonna
left a comment
Collaborator
There was a problem hiding this comment.
Did you run this end to end, and check that the resulting file is identical, including data types?
Collaborator
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request overview
Converts CBECS processor from pandas to polars.
Pull Request Author
This pull request makes changes to (select all the apply):
Pull Request Author Checklist:
Pull Request Reviewer Checklist:
.ymlandREADME.mdfiles updatedtest/reporting_measure_tests.txt,test/workflow_measure_tests.txt, ortest/upgrade_measure_tests.txtComStock Licensing Language - Add to Beginning of Each Code File