Update CI to cuda13 - #1950
Conversation
First, we migrate the nightly and PR ci from cuda12 to cuda13 Second, we purge the unused container CI and now deprecated precommit workflow. Note that precommit is running as a github installed app here, and we don't need it as a dedicated action.
I updated precommit to check .yaml and .yml, and many files had incorrect license. This fixes them.
CODEOWNERS review mapCurrent for commit ⏳ @coreyjadams — 21 file(s)
⏳ @ktangsali — 20 file(s)
⏳ @NickGeneva — 20 file(s)
No CODEOWNER
Comment |
Greptile SummaryThis PR migrates GitHub CI from CUDA 12.8 to CUDA 13.3, updates CUDA-specific extras and PyG dependency handling, broadens YAML license-header checks, and removes superseded workflows.
Important Files Changed
Reviews (1): Last reviewed commit: "While updating CI, I notice the yaml ext..." | Re-trigger Greptile |
peterdsharpe
left a comment
There was a problem hiding this comment.
Great calls all around. This bundles a bunch of small smart changes.
ktangsali
left a comment
There was a problem hiding this comment.
Looks mostly good, @coreyjadams did you mention you changed something on the license testing front? I don't see those diffs here.
Was it this change? |
|
Yes: it was exactly the change you mentioned. The license check was only looking for After I added |
|
/ok to test 5cbd2de |
PhysicsNeMo Pull Request
This PR updates our CI from cuda12 to cuda13.
It also fixes a bug in how we check yaml files for license headers. So it looks a lot bigger than it is, because I also fixed all those license headers.
Additionally, the nightly container and pre-commit workflows are deleted:
appversion of the same tool, which is faster and more efficient.Description
Checklist
Dependencies
Review Process
All PRs are reviewed by the PhysicsNeMo team before merging.
Depending on which files are changed, GitHub may automatically assign a maintainer for review.
We are also testing AI-based code review tools (e.g., Greptile), which may add automated comments with a confidence score.
This score reflects the AI’s assessment of merge readiness and is not a qualitative judgment of your work, nor is
it an indication that the PR will be accepted / rejected.
AI-generated feedback should be reviewed critically for usefulness.
You are not required to respond to every AI comment, but they are intended to help both authors and reviewers.
Please react to Greptile comments with 👍 or 👎 to provide feedback on their accuracy.