Tighten import-linter dependency contracts - #1948
Merged
peterdsharpe merged 5 commits intoAug 31, 2026
Merged
Conversation
Collaborator
Author
|
/ok to test ac3f81b |
Contributor
CODEOWNERS review mapCurrent for commit No CODEOWNER
Comment |
Contributor
Greptile SummaryTightens import-linter dependency boundaries while preserving the intentionally non-exhaustive
Important Files Changed
Reviews (1): Last reviewed commit: "Tighten import-linter contracts" | Re-trigger Greptile |
Collaborator
Author
|
/ok to test 2c9b79e |
Collaborator
Author
|
/ok to test a987505 |
coreyjadams
approved these changes
Aug 25, 2026
coreyjadams
left a comment
Collaborator
There was a problem hiding this comment.
Thanks, @peterdsharpe , for doing some maintenance here. Good to clean this up periodically. Left a few minor comments but overall its looking good.
6 tasks
Collaborator
Author
|
/ok to test 4e7eefb |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tighten PhysicsNeMo's import boundaries by making complete contracts exhaustive, assigning previously untracked modules to their intended layers, and making currently independent siblings explicitly non-shareable. The partial
nncontract remains non-exhaustive, whilecompatandconftestremain explicit top-level exceptions.Before
After
exhaustive = True deploy | active_learning | diffusion | sym samplers | metrics multi_diffusion | preconditioners | guidance utils | base