Skip to content

Tighten import-linter dependency contracts - #1948

Merged
peterdsharpe merged 5 commits into
NVIDIA:mainfrom
peterdsharpe:codex/tighten-importlinter-contracts
Aug 31, 2026
Merged

Tighten import-linter dependency contracts#1948
peterdsharpe merged 5 commits into
NVIDIA:mainfrom
peterdsharpe:codex/tighten-importlinter-contracts

Conversation

@peterdsharpe

Copy link
Copy Markdown
Collaborator

Summary

Tighten PhysicsNeMo's import boundaries by making complete contracts exhaustive, assigning previously untracked modules to their intended layers, and making currently independent siblings explicitly non-shareable. The partial nn contract remains non-exhaustive, while compat and conftest remain explicit top-level exceptions.

Before

active_learning : diffusion
sym

samplers : metrics
multi_diffusion : preconditioners : guidance
utils

After

exhaustive = True

deploy | active_learning | diffusion | sym

samplers | metrics
multi_diffusion | preconditioners | guidance
utils | base

@copy-pr-bot

copy-pr-bot Bot commented Aug 24, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@peterdsharpe

Copy link
Copy Markdown
Collaborator Author

/ok to test ac3f81b

@github-actions

Copy link
Copy Markdown
Contributor

CODEOWNERS review map

Current for commit ac3f81b840b3. An approval covers every file listed for that owner; one owner is sufficient for shared files.

No CODEOWNER

  • .importlinter

Comment /codeowners-info to refresh.

@peterdsharpe
peterdsharpe marked this pull request as ready for review August 24, 2026 22:43
@greptile-apps

greptile-apps Bot commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

Tightens import-linter dependency boundaries while preserving the intentionally non-exhaustive nn contract.

  • Makes complete layer contracts exhaustive, with explicit top-level exceptions for compat and conftest.
  • Assigns previously untracked modules to their intended layers.
  • Marks currently independent modules as non-shareable siblings.

Important Files Changed

Filename Overview
.importlinter Exhaustive coverage and sibling boundaries match the current package tree and import graph; no contract-breaking omissions or imports were identified.

Reviews (1): Last reviewed commit: "Tighten import-linter contracts" | Re-trigger Greptile

@peterdsharpe

Copy link
Copy Markdown
Collaborator Author

/ok to test 2c9b79e

@peterdsharpe

Copy link
Copy Markdown
Collaborator Author

/ok to test a987505

@coreyjadams coreyjadams left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @peterdsharpe , for doing some maintenance here. Good to clean this up periodically. Left a few minor comments but overall its looking good.

Comment thread .importlinter Outdated
Comment thread .importlinter
@peterdsharpe

Copy link
Copy Markdown
Collaborator Author

/ok to test 4e7eefb

@peterdsharpe
peterdsharpe added this pull request to the merge queue Aug 31, 2026
Merged via the queue into NVIDIA:main with commit 2e57029 Aug 31, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants