Replace localstack with ministack - #796
Conversation
📝 WalkthroughWalkthroughThe local AWS service image changes from ChangesLocal AWS image update
Estimated code review effort: 1 (Trivial) | ~2 minutes Mergeability Score: 🔵 Low · up to The PR replaces the local AWS emulator image across four development Compose files. The change is mergeable with owner awareness, but the image should use an approved immutable digest and have its licensing and attribution confirmed to avoid bounded dependency-provenance or compliance risk. Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@src/control-plane-services/cloud-functions/local_env/docker-compose.test.yml`:
- Line 21: Replace the MiniStack tag with the resolved multi-platform manifest
digest for ministackorg/ministack:1.4.16 in all four Compose files:
src/control-plane-services/cloud-functions/local_env/docker-compose.test.yml:21-21,
src/control-plane-services/cloud-functions/local_env/docker-compose.yml:21-21,
src/control-plane-services/instance-cluster-management/local_env/docker-compose.test.yml:21-21,
and
src/control-plane-services/instance-cluster-management/local_env/docker-compose.yml:42-42.
Use the identical immutable digest everywhere, verify its license against
.allowed-licenses.txt, and add the required NOTICE or attribution entry if
applicable.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: adb9e4b2-dfbe-424f-94ff-1644365be7bf
📒 Files selected for processing (4)
src/control-plane-services/cloud-functions/local_env/docker-compose.test.ymlsrc/control-plane-services/cloud-functions/local_env/docker-compose.ymlsrc/control-plane-services/instance-cluster-management/local_env/docker-compose.test.ymlsrc/control-plane-services/instance-cluster-management/local_env/docker-compose.yml
| services: | ||
| aws: | ||
| image: localstack/localstack:4.3 | ||
| image: ministackorg/ministack:1.4.16 |
There was a problem hiding this comment.
🔒 Security & Privacy | 🟡 Minor | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
#!/usr/bin/env bash
set -euo pipefail
image='ministackorg/ministack:1.4.16'
docker buildx imagetools inspect "$image"
test -f .allowed-licenses.txt
rg -n -i '\bMIT\b|ministack' .allowed-licenses.txt
fd -HI -t f '^(NOTICE|NOTICE\..*|THIRD_PARTY.*)$' .Repository: NVIDIA/nvcf
Length of output: 193
Use one immutable and approved MiniStack image reference in all four Compose files.
Resolve the multi-platform manifest digest for ministackorg/ministack:1.4.16, use the same digest in all four Compose files, and verify the license against .allowed-licenses.txt. Add the required NOTICE or attribution entry if applicable.
📍 Affects 4 files
src/control-plane-services/cloud-functions/local_env/docker-compose.test.yml#L21-L21(this comment)src/control-plane-services/cloud-functions/local_env/docker-compose.yml#L21-L21src/control-plane-services/instance-cluster-management/local_env/docker-compose.test.yml#L21-L21src/control-plane-services/instance-cluster-management/local_env/docker-compose.yml#L42-L42
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@src/control-plane-services/cloud-functions/local_env/docker-compose.test.yml`
at line 21, Replace the MiniStack tag with the resolved multi-platform manifest
digest for ministackorg/ministack:1.4.16 in all four Compose files:
src/control-plane-services/cloud-functions/local_env/docker-compose.test.yml:21-21,
src/control-plane-services/cloud-functions/local_env/docker-compose.yml:21-21,
src/control-plane-services/instance-cluster-management/local_env/docker-compose.test.yml:21-21,
and
src/control-plane-services/instance-cluster-management/local_env/docker-compose.yml:42-42.
Use the identical immutable digest everywhere, verify its license against
.allowed-licenses.txt, and add the required NOTICE or attribution entry if
applicable.
Sources: Coding guidelines, MCP tools
|
@Nahuel990 we require an issue associated with MRs. In the issue please include what benefit this gives, as I consider this a feature request/minor feature not a bug fix or improvement. |
2 participants
Swaps
localstack/localstack:4.3forministackorg/ministack:1.4.16in the fourlocal_envcompose files. ministack is an open-source (MIT) AWS emulator that serves the same APIs on the same port (4566) and honours bothSERVICESand/etc/localstack/init/ready.dinit scripts, so no other changes are needed. Pinned to a released version to match this repo's pinning.Disclosure: I maintain ministack.
Verified locally against this repo, running the actual
aws/startup.shinit scripts unchanged:SERVICES=sts,s3): init bucketsb-strap-results/b-strap-assetscreated, STSget-caller-identityand S3 put/get work.SERVICES=sqs,sns,sts): FIFO SQS queues + FIFO SNS topic created, SNS→SQS subscribe withRawMessageDeliveryreturns a SubscriptionArn, IAM role created,awslocalpresent and working.Scoped to the compose files only. The Testcontainers-based Go/Rust tests still pin LocalStack and are left unchanged (happy to do a follow-up).
Summary by CodeRabbit