fix(metrics): align metric descriptions with updated docs#2017
Open
poroh wants to merge 1 commit into
Open
Conversation
10 tasks
srinivasadmurthy
approved these changes
May 29, 2026
Contributor
|
Should we add the core_metrics.md to .gitignore so that people don't check it in unnecessarily? |
Contributor
Author
No. core_metrics.md should be checked in if changed. The problem was that this autogenerated file was manually changed without changing code-level source. |
Matthias247
approved these changes
May 29, 2026
Signed-off-by: Dmitry Porokh <dporokh@nvidia.com>
poroh
force-pushed
the
metrics-docs-nico-health-descriptions
branch
from
d567271 to
d9245f5
Compare
poroh
commented
May 29, 2026
| <tr><td>nico_switches_total</td><td>gauge</td><td>The total number of nico_switches in the system</td></tr> | ||
| <tr><td>nico_total_ips_count</td><td>gauge</td><td>The total number of ips in the site</td></tr> | ||
| <tr><td>nico_unavailable_dpu_nic_firmware_update_count</td><td>gauge</td><td>The number of machines in the system that need a firmware update but are unavailable for update.</td></tr> | ||
| <tr><td>carbide_active_host_firmware_update_count</td><td>gauge</td><td>The number of host machines in the system currently working on updating their firmware.</td></tr> |
Contributor
Author
There was a problem hiding this comment.
These metrics were wrongly renamed by #1974 . Real metrics name hasn't been renamed yet. This file is auto-generated and should keep it this way, without manual editing. See line 3.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Docs were manually update. This PR fixes metrics name inside code to match docs.
Also it adds additional metrics that are generated during integration tests run.
Type of Change
Related Issues (Optional)
Breaking Changes
Testing
Additional Notes