build(isolated-packages): add CI checks for isolated package builds#2002
Open
jayzhudev wants to merge 4 commits into
Open
build(isolated-packages): add CI checks for isolated package builds#2002jayzhudev wants to merge 4 commits into
jayzhudev wants to merge 4 commits into
Conversation
## Description Some workspace crates only build because another crate happens to enable the dependency features they need. As a best practice, each crate should declare the dependency features it uses directly. This PR adds a step to lint-police to check isolated package builds using `xtask`. It also fixes existing build issues by declaring implicitly used feature flags in individual packages. Tradeoffs: - `lint-police` will take longer to finish because the new check runs `cargo check --locked -p <package>` for each workspace package. - The check runs in the last step in `lint-police` so faster lint failures are reported first. ## Type of Change <!-- Check one that best describes this PR --> - [ ] **Add** - New feature or capability - [ ] **Change** - Changes in existing functionality - [x] **Fix** - Bug fixes - [ ] **Remove** - Removed features or deprecated functionality - [x] **Internal** - Internal changes (refactoring, tests, docs, etc.) ## Related Issues Closes NVIDIA#1949 ## Breaking Changes - [ ] This PR contains breaking changes ## Testing - [ ] Unit tests added/updated - [ ] Integration tests added/updated - [x] Manual testing performed - [ ] No testing required (docs, internal refactor, etc.) Signed-off-by: Jay Zhu <jayzhu@nvidia.com>
poroh
approved these changes
May 29, 2026
Contributor
Author
|
@NVIDIA/dsx-sw-cicd could you please review this PR when there's a chance? Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Some workspace crates only build because another crate happens to enable the dependency features they need. As a best practice, each crate should declare the dependency features it uses directly.
This PR adds a step to lint-police to check isolated package builds using
xtask. It also fixes existing build issues by declaring implicitly used feature flags in individual packages.Tradeoffs:
lint-policewill take longer to finish because the new check runscargo check --locked -p <package>for each workspace package.lint-policeso faster lint failures are reported first.Type of Change
Related Issues
Closes #1949
Breaking Changes
Testing