feat: HostInband segment support for DPU-less provisioning#1978
Open
s3rj1k wants to merge 1 commit into
Open
Conversation
Add HostInband as a first-class provisioning network: site-explorer includes HostInband segments in its scan set and tolerates a BMC interface preallocated on one (same machine_id), and admin-cli gains a host-inband-segment mode that creates a flat VPC + HostInband segment via new RPCs. Signed-off-by: s3rj1k <evasive.gyron@gmail.com>
s3rj1k
force-pushed
the
feat/host-inband-networking
branch
from
91d4286 to
9c0f89f
Compare
Collaborator
|
This is giving the ability for the admin-cli dev-env command to create a Flat VPC and a host-inband segment type to do testing in dev-env? |
Author
Yes, flat network setup for devenv, when BMCs and nodes are on same subnet, still uses dhcp-relay though. |
Collaborator
|
/ok to test 9c0f89f |
Matthias247
reviewed
May 28, 2026
| let mut txn = self.txn_begin().await?; | ||
|
|
||
| let underlay_segments = | ||
| // BMCs that share a host network end up preallocated on a HostInband |
Contributor
| continue; | ||
| } | ||
|
|
||
| let ns_id: NetworkSegmentId = uuid::Uuid::new_v4().into(); |
Contributor
There was a problem hiding this comment.
These are covered by different roles:
- The inband segment always needs to be created by the site admin and is created only once
- The "flat VPC" will be created by each tenant that wants to use it.
As a result of this, the create_inband_segment should not be here, and the API might need to error out.
@chet for more input how flat VPCs are supposed to be created.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add HostInband as a first-class provisioning network: site-explorer includes HostInband segments in its scan set and tolerates a BMC interface preallocated on one (same machine_id), and admin-cli gains a host-inband-segment mode that creates a flat VPC + HostInband segment via new RPCs.
Type of Change
Related Issues (Optional)
Breaking Changes
Testing
Additional Notes