Support Data Center precompiled driver container for Arm (Ubuntu 24.04)#533
Open
shivakunv wants to merge 1 commit into
Open
Support Data Center precompiled driver container for Arm (Ubuntu 24.04)#533shivakunv wants to merge 1 commit into
shivakunv wants to merge 1 commit into
Conversation
6405d48 to
574ce43
Compare
20726a8 to
46aa0d1
Compare
c008150 to
b684015
Compare
shivakunv
commented
Feb 19, 2026
rahulait
reviewed
Feb 19, 2026
There was a problem hiding this comment.
Pull request overview
This pull request adds ARM64 (aarch64) platform support to the Ubuntu 24.04 precompiled driver container builds, while maintaining AMD64 as the default architecture. The changes enable multi-platform Docker builds and update the CI/CD pipeline to handle both architectures.
Changes:
- Added ARM64 platform support for Ubuntu 24.04 precompiled driver containers with architecture-specific package handling
- Updated CI workflow to build, test, and publish both AMD64 and ARM64 artifacts with platform-specific suffixes
- Modified Holodeck test infrastructure to support ARM64 instances (g5g.xlarge in us-west-2) and Ubuntu 24.04 OS specification
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| ubuntu24.04/precompiled/nvidia-driver | Added conditional installation of libnvidia-fbc1 package (AMD64 only) |
| ubuntu24.04/precompiled/local-repo.sh | Added conditional downloads for ARM64-incompatible packages (linux-signatures-nvidia, libnvidia-fbc1) |
| ubuntu24.04/precompiled/Dockerfile | Made i386 architecture and CUDA repository URLs conditional based on target architecture |
| tests/scripts/findkernelversion.sh | Added optional PLATFORM_SUFFIX parameter for artifact matching and platform-specific manifest inspection |
| tests/scripts/ci-precompiled-helpers.sh | Added PLATFORM_SUFFIX parameter support for kernel version testing |
| tests/holodeck_ubuntu24.04.yaml | Removed file (merged into holodeck_ubuntu.yaml) |
| tests/holodeck_ubuntu.yaml | Removed hardcoded ingressIpRanges and AMI, added OS specification support |
| multi-arch.mk | Removed AMD64-only platform restriction for ubuntu24.04 builds |
| Makefile | Added DOCKER_BUILD_PLATFORM_OPTIONS to base image build targets |
| .github/workflows/precompiled.yaml | Added platform matrix dimension, platform-aware artifact naming, ARM64 e2e testing with appropriate instance types, and Holodeck version update |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ee1265d to
49429dd
Compare
32e68a1 to
cdbfe9a
Compare
cdbfe9a to
e224399
Compare
shivakunv
commented
Feb 25, 2026
ed896ab to
a48e0c3
Compare
shivakunv
commented
Mar 2, 2026
Contributor
Author
|
@rajathagasthya @tariq1890 @tariq1890 : PTAL |
2f00f8b to
4a75c51
Compare
4a75c51 to
c7ce51a
Compare
8b1afd4 to
dd078b8
Compare
tariq1890
reviewed
Apr 17, 2026
| # Fetch GPG keys for CUDA repo | ||
| RUN apt-key del 3bf863cc && \ | ||
| # Fetch GPG keys for CUDA repo (architecture-specific) | ||
| RUN CUDA_ARCH=$([ "$TARGETARCH" = "arm64" ] && echo "sbsa" || echo "x86_64") && \ |
Contributor
There was a problem hiding this comment.
Why are we using sbsa? If I remember correctly, sbsa is specifically for Tegra-based arm64 machines
Contributor
Author
There was a problem hiding this comment.
tariq1890
reviewed
Apr 17, 2026
dd078b8 to
783e783
Compare
783e783 to
d44324e
Compare
d44324e to
7d8aff1
Compare
7d8aff1 to
c035d23
Compare
8f74fc9 to
6c73138
Compare
Signed-off-by: Shiva Kumar (SW-CLOUD) <shivaku@nvidia.com>
6c73138 to
89ca059
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Code Changes Summary:
Platform Support
Added support for the ARM64 platform.
AMD64 remains the default architecture.
Artifacts Update
ARM64 build artifacts are now uploaded with the -arm64 suffix.
Instance Type and Region Mapping
g4dn.xlarge:
Architecture: AMD64
Supported Region: us-west-1
Used for AMD64 builds.
g5g.xlarge:
Architecture: ARM64
Supported Region: us-west-2
Used for ARM64 builds.
Fixes https://github.com/NVIDIA/cloud-native-team/issues/276
passed pipeline: https://github.com/NVIDIA/gpu-driver-container/actions/runs/22180871853
passed pipeline: https://github.com/NVIDIA/gpu-driver-container/actions/runs/22337833186