chore(forms): cover unset disabled aria in state controller - #233
Merged
Conversation
Adds a unit test for the unset disabled branch in state-disabled.controller.ts, raising line coverage from 90.9% to 100% and branch coverage from 87.5% to 100%. No behavior change. Signed-off-by: Cursor Agent <cursoragent@cursor.com>
coryrylan
approved these changes
Aug 21, 2026
Collaborator
|
🎉 This issue has been resolved in version 2.4.0 🎉 |
Collaborator
|
🎉 This issue has been resolved in version 2.0.1 🎉 |
Collaborator
|
🎉 This issue has been resolved in version 2.1.3 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
projects/forms/src/internal/controllers/state-disabled.controller.tsAdds one unit test in the existing
state-disabled.controller.test.tsfor the unsetdisabledpath (undefinedandnull), which clearsaria-disabledand does not apply:state(disabled).Coverage
No other file's coverage decreased.
API
No public API changed. Production source is untouched.
Left alone
type-popover-trigger.controller.ts,select.ts)_internalsnon-null assertions already used by this suiteVerification
From
projects/forms:lint,test(286 passing), andtest:lighthousepassed.test:types,test:axe,test:ssr, andtest:visualare not defined for this package. Rootpnpm run cipassed.