Skip to content

fix(styles): native text-box support #231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
coryrylan merged 1 commit into from
Aug 21, 2026
+2 −32
Merged

fix(styles): native text-box support #231

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions projects/styles/src/index.test.lighthouse.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ describe('lighthouse report', () => {
});

test('typography.css should remain within compressed bundle limits', async () => {
expect(report.payload.css.requests['typography.css']!.kb).toBeLessThan(1.85);
expect(report.payload.css.requests['typography.css']!.kb).toBeLessThan(1.7);
});

test('view-transitions.css should remain within compressed bundle limits', async () => {
Expand All @@ -50,6 +50,6 @@ describe('lighthouse bundle report', () => {
});

test('bundles/index.css should remain within compressed bundle limits', async () => {
expect(report.payload.css.requests['index.css']!.kb).toBeLessThan(3.2);
expect(report.payload.css.requests['index.css']!.kb).toBeLessThan(3.1);
});
});
30 changes: 0 additions & 30 deletions projects/styles/src/typography.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,36 +37,6 @@ body[nve-text],
text-box: none !important;
}

@supports not (text-box: trim-both cap alphabetic) {
/* https://seek-oss.github.io/capsize/ (firefox, drop in v154) */
[nve-text] {
--_capsize-offset: -0.1818em;
}

:is([nve-text~='display'], [nve-text~='heading'], [nve-text~='body'], [nve-text~='label'])::before {
content: '';
margin-block-end: var(--_capsize-offset);
display: table;
}

:is([nve-text~='display'], [nve-text~='heading'], [nve-text~='body'], [nve-text~='label'])[nve-text]::after {
content: '';
margin-block-start: var(--_capsize-offset);
display: table;
}

[nve-text~='trim:none']::before,
[nve-text~='trim:none']::after {
content: none !important;
}

[nve-text~='truncate'] {
&::after {
--_capsize-offset: 0;
}
}
}

[nve-text~='display'] {
--_font-size: var(--nve-ref-font-size-1000);
--_line-height: var(--nve-ref-font-line-height-tight);
Expand Down