Fix benchmark regressions from #1846 - #2384
Open
achirkin wants to merge 9 commits into
Open
Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Contributor
Author
|
/ok to test |
Contributor
Author
|
/ok to test |
Contributor
|
@achirkin its too late for anything to be merged into 26.08. You'll need to retarget to main. |
…enchmark-provided dataset to avoid ambiguity w.r.t. data residence
Contributor
Author
|
Sure. I'll just finish it up today and let you decide whether to re-target and whether to optionally backport the fixes later if necessary. |
tfeher
requested changes
Aug 3, 2026
tfeher
left a comment
Contributor
There was a problem hiding this comment.
Thanks Artem, most of it looks good, but I have some questions.
cjnolet
previously approved these changes
Aug 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix a few issues introduced to the benchmark executables limiting the functionality:
Library changes (non-breaking):
cuvs::make_vpq_datasetto bring the ability to quantize from host data without copying the whole dataset and to quantize from fp16 data (the relevant symbols were hidden).