Add missing template disambiguators - #3433
Open
Yinwei-Zhang wants to merge 1 commit into
Open
Conversation
Yinwei-Zhang
marked this pull request as ready for review
August 5, 2026 01:56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add missing
templatedisambiguators to four dependent member-template calls in SM100 and SM103 GEMM kernels.Root cause
CollectiveMainloopandCollectiveEpilogueare aliases of class template parameters, so member-template calls through their instances are dependent names. Standard C++ requires thetemplatedisambiguator in these expressions.NVCC accepts the existing non-empty calls through permissive parsing, but stricter C++ frontends can reject them because
<is not unambiguously parsed as the beginning of a template argument list.Changes
CollectiveMainloop::load_initandCollectiveMainloop::tensormaps_initcalls in the SM100 array/grouped kernel.CollectiveEpilogue::loadcalls in the SM103 block-scaled GEMM and array/grouped GEMM kernels.This is a syntax-only portability fix with no intended runtime or code-generation change.
Validation
git diff --check75_blackwell_grouped_gemmforsm_100awith CUDA 13.2.89_sm103_fp4_ultra_gemmwithCUTLASS_NVCC_ARCHS=103a.90_sm103_fp4_ultra_grouped_gemmwithCUTLASS_NVCC_ARCHS=103a.