cuda.bindings: Fix API status handling - #2530
Merged
Merged
Conversation
Contributor
juenglin
force-pushed
the
cufile-check-status-fix
branch
from
August 7, 2026 18:06
1c3d6f3 to
9ef5766
Compare
mdboom
approved these changes
Aug 7, 2026
mdboom
left a comment
Contributor
There was a problem hiding this comment.
LGTM.
The unrelated changes make sense given the recent generator changes. We should probably do a "catch-up" PR for all of the libraries, but that can be a separate PR.
Contributor
Author
|
/ok to test |
Contributor
@juenglin, there was an error processing your request: See the following link for more information: https://docs.gha-runners.nvidia.com/cpr/e/1/ |
juenglin
marked this pull request as ready for review
August 7, 2026 18:36
Contributor
Author
|
/ok to test 9ef5766 |
This comment has been minimized.
This comment has been minimized.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #2299
Test
get_bar_size_in_kbfailed on an GH200 system. The clue is in the error shared in #2299:The
cufilestatus struct has two fields, one forcufileproper, and a second for forwarding potential CUDA driver errors. The CUDA driver error field should be ignored unless thecufileerror isCU_FILE_CUDA_DRIVER_ERROR. So the test failed becausecuda.bindingsincorrectly raised acuFileError.The issue fix is here. The PR contains other unrelated changes from re-generating
cufilebindings.