-
Notifications
You must be signed in to change notification settings - Fork 317
Make Windows static library searches architecture-aware #2491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -9,6 +9,7 @@ | |
| from cuda.pathfinder._utils.env_vars import get_cuda_path_or_home | ||
| from cuda.pathfinder._utils.find_sub_dirs import find_sub_dirs_all_sitepackages | ||
| from cuda.pathfinder._utils.platform_aware import IS_WINDOWS | ||
| from cuda.pathfinder._utils.windows_arch import windows_python_arch | ||
|
|
||
|
|
||
| class StaticLibNotFoundError(RuntimeError): | ||
|
|
@@ -32,17 +33,28 @@ class _StaticLibInfo(TypedDict): | |
| site_packages_dirs: tuple[str, ...] | ||
|
|
||
|
|
||
| def _cudadevrt_info() -> _StaticLibInfo: | ||
| if not IS_WINDOWS: | ||
| return { | ||
| "filename": "libcudadevrt.a", | ||
| "ctk_rel_paths": ("lib64", "lib"), | ||
| "conda_rel_paths": ("lib",), | ||
| "site_packages_dirs": ("nvidia/cu13/lib", "nvidia/cuda_runtime/lib"), | ||
| } | ||
|
|
||
| arch_dir = windows_python_arch() | ||
| component_wheel_dirs = ("nvidia/cuda_runtime/lib/x64",) if arch_dir == "x64" else () | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I expect this hardcoded path
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. From previous releases (cuda 12), the wheel structure remained stable throughout the major version lifetime. I expect cuda 13 to do the same. |
||
| conda_fallback_dirs = ("lib",) if arch_dir == "x64" else () | ||
| return { | ||
| "filename": "cudadevrt.lib", | ||
| "ctk_rel_paths": (os.path.join("lib", arch_dir),), | ||
| "conda_rel_paths": (os.path.join("lib", arch_dir), *conda_fallback_dirs), | ||
| "site_packages_dirs": (f"nvidia/cu13/lib/{arch_dir}", *component_wheel_dirs), | ||
| } | ||
|
|
||
|
|
||
| _SUPPORTED_STATIC_LIBS_INFO: dict[str, _StaticLibInfo] = { | ||
| "cudadevrt": { | ||
| "filename": "cudadevrt.lib" if IS_WINDOWS else "libcudadevrt.a", | ||
| "ctk_rel_paths": (os.path.join("lib", "x64"),) if IS_WINDOWS else ("lib64", "lib"), | ||
| "conda_rel_paths": ((os.path.join("lib", "x64"), "lib") if IS_WINDOWS else ("lib",)), | ||
| "site_packages_dirs": ( | ||
| ("nvidia/cu13/lib/x64", "nvidia/cuda_runtime/lib/x64") | ||
| if IS_WINDOWS | ||
| else ("nvidia/cu13/lib", "nvidia/cuda_runtime/lib") | ||
| ), | ||
| }, | ||
| "cudadevrt": _cudadevrt_info(), | ||
| } | ||
|
|
||
| SUPPORTED_STATIC_LIBS: tuple[str, ...] = tuple(sorted(_SUPPORTED_STATIC_LIBS_INFO.keys())) | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might be risky if non-windows non-linux (RISC-V)? But yes or no I think this is good enough for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, definitely good for now. We have many other existing conditions like this that'd need revisiting.