Skip to content

[libcu++] Fix Overflow in Dynamic Shared Memory Validation #9727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
davebayer wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −2
Open

[libcu++] Fix Overflow in Dynamic Shared Memory Validation #9727

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions libcudacxx/include/cuda/__launch/configuration.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@

# include <cuda/__driver/driver_api.h>
# include <cuda/__hierarchy/hierarchy_dimensions.h>
# include <cuda/__numeric/mul_overflow.h>
# include <cuda/__numeric/overflow_cast.h>
# include <cuda/__ptx/instructions/get_sreg.h>
# include <cuda/std/__cstddef/types.h>
Expand Down Expand Up @@ -416,8 +417,9 @@ _CCCL_TEMPLATE(class _Tp)
_CCCL_REQUIRES(::cuda::std::is_unbounded_array_v<_Tp>)
[[nodiscard]] _CCCL_HOST_API constexpr dynamic_shared_memory_option<_Tp> dynamic_shared_memory(::cuda::std::size_t __n)
{
using value_type = typename dynamic_shared_memory_option<_Tp>::value_type;
if (__n * sizeof(value_type) > __max_portable_dyn_smem_size)
constexpr auto __value_type_size = sizeof(typename dynamic_shared_memory_option<_Tp>::value_type);
const auto [__dyn_smem_size, __overflow] = ::cuda::mul_overflow(__n, __value_type_size);
if (__overflow || __dyn_smem_size > __max_portable_dyn_smem_size)
{
_CCCL_THROW(::std::invalid_argument, "portable dynamic shared memory limit exceeded");
}
Expand Down
Loading