[cuda.compute]: fix h_init + d_out type mismatch bug in reduction algorithms - #10937
[cuda.compute]: fix h_init + d_out type mismatch bug in reduction algorithms#10937NaderAlAwar wants to merge 3 commits into
h_init + d_out type mismatch bug in reduction algorithms#10937Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Included review availability: Your plan provides up to 12 included reviews per hour; 10 remain after this review. 📝 WalkthroughSummary by CodeRabbit
WalkthroughReduce and segmented-reduce now convert accumulator values to the output iterator type during final stores. Native and Python tests cover differing output dtypes, and Python documentation describes scalar accumulation and output conversion. ChangesReduce output conversion
Assessment against linked issues
Suggested reviewers: Merge Risk: ⚪ Minimal · up to This change is merge-ready after normal checks and review; no actionable merge-blocking risk remains. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 88c92229-3c97-4892-b855-8d1bde5fb47d
📒 Files selected for processing (8)
c/parallel/src/reduce.cuc/parallel/src/segmented_reduce.cuc/parallel/test/test_reduce.cppc/parallel/test/test_segmented_reduce.cpppython/cuda_cccl/cuda/compute/algorithms/_reduce.pypython/cuda_cccl/cuda/compute/algorithms/_segmented_reduce.pypython/cuda_cccl/tests/compute/test_reduce.pypython/cuda_cccl/tests/compute/test_segmented_reduce.py
Included review availability: Your plan provides up to 12 included reviews per hour; 10 remain after this review.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
🥳 CI Workflow Results🟩 Finished in 3h 32m: Pass: 100%/112 | Total: 1d 15h | Max: 1h 00m | Hits: 100%/1467See results here. |
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Description
closes #10935
This also makes this behavior consistent with CUB
Checklist