Skip to content

[JAX][Fix] Gate collective-stream compute_on on import and silence pylint - #3329

Open
phu0ngng wants to merge 1 commit into
NVIDIA:mainfrom
phu0ngng:jax_compute_on_version
Open

[JAX][Fix] Gate collective-stream compute_on on import and silence pylint#3329
phu0ngng wants to merge 1 commit into
NVIDIA:mainfrom
phu0ngng:jax_compute_on_version

Conversation

@phu0ngng

@phu0ngng phu0ngng commented Aug 7, 2026

Copy link
Copy Markdown
Collaborator

Description

Please include a brief summary of the changes, relevant motivation and context.

Fixes # (issue)

Type of change

  • Documentation change (change only to the documentation, either a fix or a new content)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Infra/Build change
  • Code refactoring

Changes

Please list the changes introduced in this PR:

  • Change A
  • Change B

Checklist:

  • I have read and followed the contributing guidelines
  • The functionality is complete
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

…not-callable

Signed-off-by: Phuong Nguyen <phuonguyen@nvidia.com>
@phu0ngng

phu0ngng commented Aug 7, 2026

Copy link
Copy Markdown
Collaborator Author

/te-ci L1 JAX

@greptile-apps

greptile-apps Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

The PR strengthens the JAX collective-stream feature gate by checking that jax.experimental.compute_on.compute_on can actually be imported and caching the result. It also suppresses a known false-positive pylint warning at the call site.

  • Require both the minimum JAX version and availability of the optional compute_on API.
  • Disable the not-callable pylint warning for the imported decorator factory.

Confidence Score: 5/5

The PR appears safe to merge, with no actionable runtime, compatibility, or security defects identified.

The feature gate now verifies the same import used by the collective-stream wrapper, while the other change affects linting only.

Important Files Changed

Filename Overview
transformer_engine/jax/version_utils.py Adds a cached importability check to prevent collective-stream support from being enabled when the required experimental JAX API is absent.
transformer_engine/jax/cpp_extensions/ep.py Adds a narrowly scoped pylint suppression without changing runtime behavior.

Reviews (1): Last reviewed commit: "[JAX] Gate collective-stream compute_on ..." | Re-trigger Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant