-
Notifications
You must be signed in to change notification settings - Fork 697
[DONOT MERGE] Wgrad cute dsl v2 #2872
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
vthumbe1503
wants to merge
11
commits into
NVIDIA:main
Choose a base branch
from
vthumbe1503:wgrad_cute_dsl_v2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+7
−4
Draft
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
4512258
integrate cudnn wgrad kernel
vthumbe1503 18fc3af
have only cute dsl for wgrad
vthumbe1503 5d1a077
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 9598847
revert the change for cudnn
vthumbe1503 f6ae933
Merge branch 'users/vthumbe/wgrad_cute_dsl' of github.com:vthumbe1503…
vthumbe1503 6af1227
remove dtype
vthumbe1503 99f9853
fix comment:
vthumbe1503 b829352
go to cublas if needed
vthumbe1503 a8c285d
changes to unblock testing
vthumbe1503 7f567b6
Merge branch 'main' into wgrad_cute_dsl_v2
vthumbe1503 699aad1
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
grouped_gemm_wgrad_kernel()never returnsNoneas documentedThe docstring promises
Nonewhen the wgrad API is unavailable, but a barefrom cudnn import grouped_gemm_wgrad_wrapper_sm100raisesImportErrorinstead of returningNone._compute_grad_params(called at lines 660 and 757) branches onif cudnn_wgrad_kernel_fn is not Nonespecifically to fall back to cublas — that fallback is unreachable because the exception propagates and crashes the backward pass on any setup wheregrouped_gemm_dglu_kernelis present butgrouped_gemm_wgrad_wrapper_sm100is not. Note that_nvidia_cudnn_frontend_supports_wgradis imported but never used; it was clearly intended as the version gate here.