Skip to content

[None][test] remove MiniMax-M2 tp16 multinode eval test case#16542

Open
jieli-matrix wants to merge 2 commits into
NVIDIA:mainfrom
jieli-matrix:remove-minimax-m2-multinode-eval
Open

[None][test] remove MiniMax-M2 tp16 multinode eval test case#16542
jieli-matrix wants to merge 2 commits into
NVIDIA:mainfrom
jieli-matrix:remove-minimax-m2-multinode-eval

Conversation

@jieli-matrix

@jieli-matrix jieli-matrix commented Jul 17, 2026

Copy link
Copy Markdown
Collaborator

MiniMax-M2 is not a supported config for multinode eval. Remove its parametrization from test_multi_nodes_eval in test_e2e.py, drop the case from the QA multinode test list, and remove its waive entry (nvbugs/6373532).

Summary by CodeRabbit

  • Tests
    • Removed the MiniMax-M2 multi-node evaluation from the integration test suite and QA test list.
    • Removed its associated test waiver and skip configuration.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • If PR introduces API changes, an appropriate PR label is added - either api-compatible or api-breaking. For api-breaking, include BREAKING in the PR title.

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, please comment /bot help.

MiniMax-M2 is not a supported config for multinode eval. Remove its
parametrization from test_multi_nodes_eval in test_e2e.py, drop the
case from the QA multinode test list, and remove its waive entry
(nvbugs/6373532).

Signed-off-by: Jie Li <lijie@nvidia.com>
@jieli-matrix
jieli-matrix enabled auto-merge (squash) July 17, 2026 09:31
@jieli-matrix

Copy link
Copy Markdown
Collaborator Author

/bot skip --comment "Only remove tests"

@coderabbitai

coderabbitai Bot commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

The MiniMax-M2 multinode evaluation target is removed from the end-to-end parameterization and QA test list, and its associated skip waiver is deleted.

Changes

Multinode test coverage

Layer / File(s) Summary
Remove MiniMax-M2 test coverage
tests/integration/defs/test_e2e.py, tests/integration/test_lists/qa/llm_function_multinode.txt, tests/integration/test_lists/waives.txt
Removes the MiniMax-M2 parameterized target, QA test-list entry, and associated skip waiver.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: ruodil

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title matches the main change and follows the required [None][type] format.
Description check ✅ Passed The description explains the issue and fix, and the template is mostly filled out; only Test Coverage is left empty.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #59950 [ skip ] triggered by Bot. Commit: 2373af9 Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #59950 [ skip ] completed with state SUCCESS. Commit: 2373af9
Skipping testing for commit 2373af9

Link to invocation

@BowenFu BowenFu left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM — removes an unsupported MiniMax-M2 tp16 multinode eval parametrization plus its QA-list entry and waiver; test-only.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants