[None][test] remove MiniMax-M2 tp16 multinode eval test case#16542
Open
jieli-matrix wants to merge 2 commits into
Open
[None][test] remove MiniMax-M2 tp16 multinode eval test case#16542jieli-matrix wants to merge 2 commits into
jieli-matrix wants to merge 2 commits into
Conversation
MiniMax-M2 is not a supported config for multinode eval. Remove its parametrization from test_multi_nodes_eval in test_e2e.py, drop the case from the QA multinode test list, and remove its waive entry (nvbugs/6373532). Signed-off-by: Jie Li <lijie@nvidia.com>
jieli-matrix
requested review from
BowenFu,
fredricz-20070104,
niukuo,
ruodil,
schetlur-nv and
yiqingy0
July 17, 2026 09:31
jieli-matrix
enabled auto-merge (squash)
July 17, 2026 09:31
Collaborator
Author
|
/bot skip --comment "Only remove tests" |
Contributor
📝 WalkthroughWalkthroughThe MiniMax-M2 multinode evaluation target is removed from the end-to-end parameterization and QA test list, and its associated skip waiver is deleted. ChangesMultinode test coverage
Estimated code review effort: 1 (Trivial) | ~2 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Collaborator
|
PR_Github #59950 [ skip ] triggered by Bot. Commit: |
Collaborator
|
PR_Github #59950 [ skip ] completed with state |
BowenFu
approved these changes
Jul 17, 2026
BowenFu
left a comment
There was a problem hiding this comment.
LGTM — removes an unsupported MiniMax-M2 tp16 multinode eval parametrization plus its QA-list entry and waiver; test-only.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MiniMax-M2 is not a supported config for multinode eval. Remove its parametrization from test_multi_nodes_eval in test_e2e.py, drop the case from the QA multinode test list, and remove its waive entry (nvbugs/6373532).
Summary by CodeRabbit
Description
Test Coverage
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
If PR introduces API changes, an appropriate PR label is added - either
api-compatibleorapi-breaking. Forapi-breaking, includeBREAKINGin the PR title.Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
To see a list of available CI bot commands, please comment
/bot help.