Skip to content

[https://nvbugs/6316983][chore] Unwaive TestQwen2_5_VL_7B::test_auto_dtype#16534

Open
yihwang-nv wants to merge 1 commit into
NVIDIA:mainfrom
yihwang-nv:yihwang-nv/unwaive_nvbug_6316983
Open

[https://nvbugs/6316983][chore] Unwaive TestQwen2_5_VL_7B::test_auto_dtype#16534
yihwang-nv wants to merge 1 commit into
NVIDIA:mainfrom
yihwang-nv:yihwang-nv/unwaive_nvbug_6316983

Conversation

@yihwang-nv

@yihwang-nv yihwang-nv commented Jul 17, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Unwaive B300/accuracy/test_llm_api_pytorch_multimodal.py::TestQwen2_5_VL_7B::test_auto_dtype
  • NVBug 6316983 (accuracy drop on B300) is closed and verified fixed (fixed 2026-07-08)

Test plan

  • CI pre-merge passes with the test re-enabled

Summary by CodeRabbit

  • Tests
    • Removed an obsolete integration-test waiver, allowing the multimodal model accuracy test to run normally.

…dtype

Bug 6316983 (TestQwen2_5_VL_7B::test_auto_dtype accuracy drop on B300)
is closed and verified fixed. Remove the waive entry.

Signed-off-by: yihwang-nv <yihwang@nvidia.com>
@coderabbitai

coderabbitai Bot commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 0fa5ad10-b0d4-4e88-9e63-fa7da41617bb

📥 Commits

Reviewing files that changed from the base of the PR and between ed1a0b9 and 772f594.

📒 Files selected for processing (1)
  • tests/integration/test_lists/waives.txt
💤 Files with no reviewable changes (1)
  • tests/integration/test_lists/waives.txt

📝 Walkthrough

Walkthrough

Removes the integration-test waiver for TestQwen2_5_VL_7B::test_auto_dtype, allowing the test to run without the previous skip entry.

Changes

Integration waiver update

Layer / File(s) Summary
Remove obsolete test waiver
tests/integration/test_lists/waives.txt
Removes the SKIP entry for the Qwen2.5-VL automatic dtype test associated with nvbug 6316983.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

Suggested reviewers: brnguyen2

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description is relevant but missing the required Description, Test Coverage, and PR Checklist sections from the template. Add the missing sections with a short issue/solution note, the tests that cover this change, and a completed PR checklist.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title matches the change and clearly states the waiver removal for the affected test.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@yihwang-nv

Copy link
Copy Markdown
Collaborator Author

/bot run --stage-list "GB300-PyTorch-1"

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #59940 [ run ] triggered by Bot. Commit: 772f594 Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #59940 [ run ] completed with state SUCCESS. Commit: 772f594
/LLM/main/L0_MergeRequest_PR pipeline #48342 (Partly Tested) completed with status: 'SUCCESS'

CI Report

Link to invocation

@BowenFu BowenFu left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM — waiver removal (unwaive) after the underlying bug was verified fixed; test-list only, no product code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants