[https://nvbugs/6467675][fix] Bump ETCD_VER from v3.6.9 to v3.7.0 in docker/common/install_etcd.sh; binary…#16533
Conversation
…pto v0.52.0 etcd v3.6.9 vendors golang.org/x/crypto v0.48.0, which is flagged by container-vulnerability scanners for CVE GHSA-q4h4-gmj2-qvw2. No later v3.6.x release bumps this transitive dependency. etcd v3.7.0 (GA 2026-07-08) bumps golang.org/x/crypto to v0.52.0. Signed-off-by: trtllm-agent <296075020+trtllm-agent@users.noreply.github.com>
📝 WalkthroughWalkthroughThe etcd installation script now downloads and extracts etcd Changesetcd version update
Estimated code review effort: 1 (Trivial) | ~2 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
docker/common/install_etcd.sh (1)
1-5: 📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick winAdd the NVIDIA copyright header.
This modified file has no NVIDIA copyright header. Add the repository-standard header and update its copyright year to 2026, as required for modified files.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@docker/common/install_etcd.sh` around lines 1 - 5, Add the repository-standard NVIDIA copyright header at the top of install_etcd.sh, before the shebang, and set its copyright year to 2026 while preserving the existing script content.Source: Coding guidelines
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In `@docker/common/install_etcd.sh`:
- Around line 1-5: Add the repository-standard NVIDIA copyright header at the
top of install_etcd.sh, before the shebang, and set its copyright year to 2026
while preserving the existing script content.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 91860d4d-0e78-47a9-87aa-7c2e9ebf140e
📒 Files selected for processing (1)
docker/common/install_etcd.sh
Summary
Test plan
Links
Summary by CodeRabbit