Skip to content

[https://nvbugs/6467675][fix] Bump ETCD_VER from v3.6.9 to v3.7.0 in docker/common/install_etcd.sh; binary…#16533

Open
trtllm-agent wants to merge 1 commit into
NVIDIA:mainfrom
tensorrt-cicd:repair-bot-bug6467675
Open

[https://nvbugs/6467675][fix] Bump ETCD_VER from v3.6.9 to v3.7.0 in docker/common/install_etcd.sh; binary…#16533
trtllm-agent wants to merge 1 commit into
NVIDIA:mainfrom
tensorrt-cicd:repair-bot-bug6467675

Conversation

@trtllm-agent

@trtllm-agent trtllm-agent commented Jul 17, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Root cause: etcd v3.6.9 vendors golang.org/x/crypto v0.48.0 (CVE GHSA-q4h4-gmj2-qvw2), which container scanners flag; no v3.6.x point release bumps this transitive dep.
  • Fix: Bump ETCD_VER from v3.6.9 to v3.7.0 in docker/common/install_etcd.sh; binary tarballs at the same storage.googleapis.com URL structure (verified 200 for both amd64 and arm64), no CLI-usage changes.
  • Automated fix generated by repair-bot

Test plan

  • Verify fix on the same GPU type as the original failure
  • Check for regressions in related tests

Links

Summary by CodeRabbit

  • Chores
    • Updated the bundled etcd installation to version 3.7.0.

…pto v0.52.0

etcd v3.6.9 vendors golang.org/x/crypto v0.48.0, which is flagged by
container-vulnerability scanners for CVE GHSA-q4h4-gmj2-qvw2. No later
v3.6.x release bumps this transitive dependency. etcd v3.7.0 (GA
2026-07-08) bumps golang.org/x/crypto to v0.52.0.

Signed-off-by: trtllm-agent <296075020+trtllm-agent@users.noreply.github.com>
@coderabbitai

coderabbitai Bot commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

The etcd installation script now downloads and extracts etcd v3.7.0 instead of v3.6.9.

Changes

etcd version update

Layer / File(s) Summary
Update etcd installer version
docker/common/install_etcd.sh
Changes ETCD_VER from v3.6.9 to v3.7.0, updating the constructed download artifact and extracted binaries.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: tburt-nv

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title matches the change and follows the required ticket-plus-type structure.
Description check ✅ Passed The description covers the issue, fix, test plan, and link, with only the checklist section omitted.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
docker/common/install_etcd.sh (1)

1-5: 📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win

Add the NVIDIA copyright header.

This modified file has no NVIDIA copyright header. Add the repository-standard header and update its copyright year to 2026, as required for modified files.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@docker/common/install_etcd.sh` around lines 1 - 5, Add the
repository-standard NVIDIA copyright header at the top of install_etcd.sh,
before the shebang, and set its copyright year to 2026 while preserving the
existing script content.

Source: Coding guidelines

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Outside diff comments:
In `@docker/common/install_etcd.sh`:
- Around line 1-5: Add the repository-standard NVIDIA copyright header at the
top of install_etcd.sh, before the shebang, and set its copyright year to 2026
while preserving the existing script content.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 91860d4d-0e78-47a9-87aa-7c2e9ebf140e

📥 Commits

Reviewing files that changed from the base of the PR and between ed1a0b9 and 0f3b256.

📒 Files selected for processing (1)
  • docker/common/install_etcd.sh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants