Skip to content

[https://nvbugs/6467688][fix] Bump the floor to mistune>=3.3.0 and update the WAR comment to reference the…#16527

Open
trtllm-agent wants to merge 1 commit into
NVIDIA:mainfrom
tensorrt-cicd:repair-bot-bug6467688
Open

[https://nvbugs/6467688][fix] Bump the floor to mistune>=3.3.0 and update the WAR comment to reference the…#16527
trtllm-agent wants to merge 1 commit into
NVIDIA:mainfrom
tensorrt-cicd:repair-bot-bug6467688

Conversation

@trtllm-agent

@trtllm-agent trtllm-agent commented Jul 17, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Root cause: constraints.txt pins mistune>=3.2.1, which allows the vulnerable 3.2.1 version (CVE GHSA-qcq2-496w-v96p) to satisfy the floor.
  • Fix: Bump the floor to mistune>=3.3.0 and update the WAR comment to reference the new advisory GHSA-qcq2-496w-v96p to match sibling-line convention.
  • Automated fix generated by repair-bot

Test plan

  • Verify fix on the same GPU type as the original failure
  • Check for regressions in related tests

Links

Summary by CodeRabbit

  • Chores
    • Updated the minimum supported Mistune version to 3.3.0.
    • Updated the associated security advisory reference.

…w-v96p)

Signed-off-by: trtllm-agent <296075020+trtllm-agent@users.noreply.github.com>
@coderabbitai

coderabbitai Bot commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

The mistune minimum version constraint was raised from >=3.2.1 to >=3.3.0, and its associated security advisory comment was updated.

Changes

Mistune security update

Layer / File(s) Summary
Update mistune constraint
constraints.txt
Raises the minimum mistune version to 3.3.0 and updates the referenced security advisory.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: yuxianq

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title is specific and matches the PR's dependency bump and advisory update.
Description check ✅ Passed The description covers the fix, root cause, test plan, and bug link, but it doesn't use the template's Description and PR Checklist sections.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@constraints.txt`:
- Around line 8-9: Add or update the NVIDIA copyright header at the beginning of
constraints.txt, before the existing base-image comments and dependency
declaration, using the appropriate current copyright year.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 06a800f1-4440-46f6-aa13-614ea932998e

📥 Commits

Reviewing files that changed from the base of the PR and between ed1a0b9 and 7cfd4fe.

📒 Files selected for processing (1)
  • constraints.txt

Comment thread constraints.txt
Comment on lines +8 to +9
# WAR against https://github.com/advisories/GHSA-qcq2-496w-v96p
mistune>=3.3.0

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win

Add or update the NVIDIA copyright header.

This modified file’s top-of-file context begins with base-image comments and does not contain the required NVIDIA copyright header/year. Please add or update it before merging.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@constraints.txt` around lines 8 - 9, Add or update the NVIDIA copyright
header at the beginning of constraints.txt, before the existing base-image
comments and dependency declaration, using the appropriate current copyright
year.

Source: Coding guidelines

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants