[https://nvbugs/6240561][fix] Autodeploy fix the deepseek accuracy drop#14774
[https://nvbugs/6240561][fix] Autodeploy fix the deepseek accuracy drop#14774nvchenghaoz wants to merge 1 commit into
Conversation
Signed-off-by: Chenghao Zhang <211069071+nvchenghaoz@users.noreply.github.com>
📝 WalkthroughWalkthroughRoPE inverse-frequency and YaRN interpolation computation in the config fallback path is refactored: inverse frequencies now derive from full-dimension indices, YaRN scaling denominator computation is unified, and interpolation uses explicit mask-based blending between frequency terms with test validation added. ChangesRoPE YaRN Computation Update
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Suggested reviewers
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@tests/unittest/auto_deploy/singlegpu/models/test_deepseek_custom.py`:
- Around line 192-194: The test currently uses torch.equal(actual, expected)
which enforces bitwise equality between actual (from
_compute_rotary_cos_sin_from_config(Factory()).cpu()) and expected (CPU),
causing cross-backend flakiness; remove that torch.equal check and rely only on
the tolerance-based assertion torch.testing.assert_close(actual, expected,
atol=3e-7, rtol=1e-4), or alternatively compute expected on the same backend as
actual by calling .to(actual.device) before comparing if you need strict
regression. Ensure changes target the assertions around
_compute_rotary_cos_sin_from_config, Factory, actual, and expected in this test.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 229e0bf0-ee11-4c7c-8b56-4765f60520da
📒 Files selected for processing (2)
tensorrt_llm/_torch/auto_deploy/transform/library/fuse_rope_mla.pytests/unittest/auto_deploy/singlegpu/models/test_deepseek_custom.py
|
Issue link : https://jirasw.nvidia.com/browse/TRTLLM-13054 |
|
/bot run --stage-list "A10-Build_Docs, A10-PackageSanityCheck-PY310-UB2204, A100X-PackageSanityCheck-PY312-UB2404, A30-AutoDeploy-1, H100_PCIe-AutoDeploy-1, DGX_B200-AutoDeploy-1, A100X-PyTorch-1, DGX_H100-4_GPUs-AutoDeploy-1, DGX_B200-4_GPUs-AutoDeploy-1, DGX_H100-4_GPUs-AutoDeploy-Post-Merge-1, DGX_B200-8_GPUs-AutoDeploy-Post-Merge-1" --disable-fail-fast |
|
PR_Github #51151 [ run ] triggered by Bot. Commit: |
|
PR_Github #51151 [ run ] completed with state
|
Summary by CodeRabbit
Description
Test Coverage
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
If PR introduces API changes, an appropriate PR label is added - either
api-compatibleorapi-breaking. Forapi-breaking, includeBREAKINGin the PR title.Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
To see a list of available CI bot commands, please comment
/bot help.