[TRTLLM-13077][feat] Deocmpose post_load_weights()#14770
Draft
chienchunhung wants to merge 1 commit into
Draft
Conversation
Signed-off-by: Chien-Chun Hung <2679986+chienchunhung@users.noreply.github.com>
Collaborator
Author
|
/bot run --disable-fail-fast |
Collaborator
|
PR_Github #51131 [ run ] triggered by Bot. Commit: |
Collaborator
|
PR_Github #51131 [ run ] completed with state
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@coderabbitai summary
Summary
Add the prep layer for staged post-load hooks without migrating existing model implementations yet.
setup_aliases(),transform_weights(), andcache_derived_state()hooks onDecoderModelForCausalLM, withpost_load_weights()preserving the current full sequence.ModelLoaderhelpers for top-level alias setup, transform walks, cache-state walks, full post-load walks, and_weights_transformedreset.reload()behavior unchanged; reload remains weight-copy-only and does not run post-load hooks.Test Plan
python3 -m pytest tests/unittest/_torch/pyexecutor/test_model_loader_mx.py -qNote: local run was blocked in this environment by missing built
tensorrt_llm.bindings; should be run in the normal TRT-LLM build/test environment.PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
If PR introduces API changes, an appropriate PR label is added - either
api-compatibleorapi-breaking. Forapi-breaking, includeBREAKINGin the PR title.Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
To see a list of available CI bot commands, please comment
/bot help.