feat(tp4): analyze fenced code in Markdown as skill implementation - #421
feat(tp4): analyze fenced code in Markdown as skill implementation#421rodboev wants to merge 3 commits into
Conversation
|
Confirming this PR addresses my reported scenario. Thanks for picking this up. Checked the diff against the two open questions I flagged in #419:
Test fixture using a fenced |
rng1995
left a comment
There was a problem hiding this comment.
[SkillSpector Review]\n\nApproved. TP4 now inspects bounded, executable-labeled Markdown fences after ordinary executable components, preserves source labels and ordering, and records conservative partial coverage on Markdown overflow. The clean/unsupported-fence and limit telemetry cases are covered, and current required checks pass.
|
Powered by Codex: PR council review result. This is a triage signal, not a maintainer approval.
|
Signed-off-by: Rod Boev <rod.boev@gmail.com>
Signed-off-by: Rod Boev <rod.boev@gmail.com>
Signed-off-by: Rod Boev <rod.boev@gmail.com>
232605a to
e970863
Compare
|
Rebased onto current main and force-pushed as |
Summary
TP4 now inspects bounded executable-language fences in Markdown/text reference files, after ordinary executable components. This closes the Markdown-only implementation blind spot while preserving existing limits and telemetry.
Root cause
TP4 built its candidate list only from components whose metadata type was one of the executable types. Markdown reference files were therefore absent from the LLM prompt, with no TP4 call or ledger evidence that implementation content had been skipped.
Changes
bash,sh,py, andjs.Preserved
Existing executable ordering, TP4 limits, deadline, prompt safety rule, finding schema, report scoring, and non-TP4 analyzers remain unchanged.
Testing
Focused TP4 tests cover the issue scenario, accepted aliases and rejected fences, the 32768-byte boundary and overflow ledger event, one-candidate aggregation, ordering, telemetry modes, and clean status preservation.
Scope
Closes #419. No live provider call is required for the focused tests.