docs: fix Windows bundled-z3 build command in CONTRIBUTING.md - #3141
Draft
pkhodade-NV wants to merge 1 commit into
Draft
docs: fix Windows bundled-z3 build command in CONTRIBUTING.md#3141pkhodade-NV wants to merge 1 commit into
pkhodade-NV wants to merge 1 commit into
Conversation
The Windows MSVC example built openshell-cli with --features bundled-z3, but openshell-cli has no Z3 dependency and does not declare that feature. Point the example at openshell-prover instead, clarify which crates link Z3, and note the CMake 4.4.3+ requirement for building Z3 from source. Fixes #3062 Signed-off-by: pkhodade-NV <pkhodade@nvidia.com>
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Windows MSVC example built openshell-cli with --features bundled-z3, but openshell-cli has no Z3 dependency and does not declare that feature. Point the example at openshell-prover instead, clarify which crates link Z3, and note the CMake 4.4.3+ requirement for building Z3 from source.
Fixes #3062
Summary
Related Issue
Changes
Testing
mise run pre-commitpassesChecklist