fix(policy): harden advisor transport proposals - #3136
Open
johntmyers wants to merge 1 commit into
Open
Conversation
Signed-off-by: John Myers <johntmyers@users.noreply.github.com>
johntmyers
requested review from
a team,
derekwaynecarr,
mrunalp and
sjenning
as code owners
September 2, 2026 17:06
|
🌿 Preview your docs: https://nvidia-preview-pr-3136.docs.buildwithfern.com/openshell |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add defense-in-depth guardrails that keep in-sandbox policy-advisor proposals on transport paths where OpenShell can enforce application authority. Agent-authored proposals may continue to omit
protocolfor the established explicit-proxy path, but they cannot request native transparent TCP or disable TLS inspection.Related Issue
No public issue: localized defense-in-depth hardening for policy-advisor proposal authority.
Changes
protocol: tcpandtls: skipendpoints at the sandbox-local parser and gateway submission boundaryTesting
mise run pre-commitpassesGIT_CONFIG_COUNT=1 GIT_CONFIG_KEY_0=tag.gpgSign GIT_CONFIG_VALUE_0=false mise run cipassesChecklist