fix(logging): harden sandbox log delivery under load - #3106
Conversation
Review findings
|
Is this a real situation? A newer supervisor connecting to an older gateway? I would imagine only the reverse being true. During an upgrade the gateway would be bounced and the sandboxes shortly after with an updated supervisor, no? |
bb77402 to
f6e9686
Compare
f6e9686 to
2c3f99a
Compare
Compress sandbox log pushes and split batches below the gateway decode limit so an oversized request cannot wedge the reconnect loop. Drop only individually undeliverable lines and report those losses to the gateway. Track channel, reconnect-buffer, and oversized-line losses cumulatively. Preserve gateway accounting across RPC reconnects, reset it with sandbox teardown, and meter both sandbox-side and ingest-side drops. Refs #1055 Signed-off-by: Kris Hicks <khicks@nvidia.com>
2c3f99a to
f572721
Compare
Summary
Compress sandbox log pushes and split batches below the gateway decode limit so an oversized request cannot wedge the reconnect loop. Drop only individually undeliverable lines and report those losses to the gateway.
Track channel, reconnect-buffer, and oversized-line losses cumulatively. Preserve gateway accounting across RPC reconnects, reset it with sandbox teardown, and meter both sandbox-side and ingest-side drops.
Related Issue
Refs #1055
Changes
Testing
mise run pre-commitpassesChecklist